Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: revert "Use HTTP/2 for all upstream and peer-to-peer connections… #1310

Merged
merged 1 commit into from
Sep 4, 2024
Merged

fix: revert "Use HTTP/2 for all upstream and peer-to-peer connections… #1310

merged 1 commit into from
Sep 4, 2024

Conversation

kentquirk
Copy link
Contributor

… (#1269)"

This reverts commit 24436a5.

Which problem is this PR solving?

  • We see what appears to be a memory leak, and it seems like it might be in the connections, so we're going to try reverting this to see if it fixes it.

@kentquirk kentquirk requested a review from a team as a code owner September 4, 2024 19:53
@kentquirk kentquirk changed the title Revert "fix: Use HTTP/2 for all upstream and peer-to-peer connections… fix: revert "Use HTTP/2 for all upstream and peer-to-peer connections… Sep 4, 2024
@kentquirk kentquirk merged commit 26814ac into main Sep 4, 2024
6 of 7 checks passed
@kentquirk kentquirk deleted the revert-1269-irving.use_http2 branch September 4, 2024 20:05
@kentquirk kentquirk mentioned this pull request Sep 4, 2024
Merged
kentquirk added a commit that referenced this pull request Sep 4, 2024
@kentquirk
fix: revert the revert -- that wasn't the problem (#1311)
290152a 
Reverts #1310 since it wasn't the issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VinozzZ VinozzZ VinozzZ approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kentquirk @VinozzZ