-
Notifications
You must be signed in to change notification settings - Fork 400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more doc for ERB-Lint #1655
Conversation
I have no access to houndci/linters repo but I'm assume files are in that position to reflect other linters.
fe6bb1d
to
a14e5a6
Compare
Thanks @kennyadsl. 🙌 I added you to
If you write it up I'll copy/past right into a new Intercom page, that would be great. |
Page:https://intercom.help/hound/configuration/erb Markdown (See it raw to copy/paste):ERBReview ERB with HoundHound uses Please notice that this linter is disable by default. To enable ERB style erblint:
enabled: false By default, erblint:
enabled: true
config_file: .erb-lint.yml Note: this is changed from having |
@salbertson after reading this @gylaz comment I think we should change the |
Ah just noticed that it's already done! We are all good! |
@salbertson @gylaz I think this is ready to merge, or you do have other comments? |
ping @salbertson @gylaz 🙂 |
@kennyadsl Thank you, merged! |
👋 Hey there,
This PR completes @aldesantis and @gylaz work done into #1641 to allow linting ERB files by adding some documentation around this new addition.
Since I have no access to the
houndci/linters
repo, in the PR I assumed that:lib/linters/erb_lint
default config is located intoconfig/erb.yml
Let me know if I should change something.
Also, I think you should add an ERB help page (similar to this one) and update the supported-linters page as well. Let me know if I can be of help here.