Lint ERB files via HoundCI

[kennyadsl]

Now that Hound supports ERB linting I think it's a good idea to start using that linter in Solidus.

Linting is done with this tool: https://github.com/Shopify/erb-lint

Since we are already linting Ruby code with Rubocop I configured hound to use the same rules that we have for the rest of the application. See #2982 (comment)

What do you think?

[jacobherrington]

I'm always for this kind of thing!

[kennyadsl]

I'm not sure if we also want to lint all the current files. It's a lot of work and we could ask some help to the erblint --autocorrect command, even if it would need an accurate check of the result.

But honestly I'm more worried about breaking the commits history making git blame on specific lines more complex, do you think it's worth it?

[jacobherrington]

I personally think it's worth some short-term pain to increase the friendliness and quality of our ERB templates. Of course, it seems that you're the one doing most of the work, so it's up to you. 😉

I don't mind adding to the Git history, but other people might feel differently.

[aldesantis]

@kennyadsl I'm all for opportunistic refactoring, so I wouldn't fix current files all in one go as it's a lot of work. Instead, let's fix issues as they arise, what do you think?

[kennyadsl]

Yes, probably that's the best option, considering also that our admin UI could need a look and feed refresh sooner or later and we'd touch those files anyway.

[aitbw]

My two cents: I think the best approach when fixing linting issues is to tackle one folder per PR. For example: under backend/app/views/spree/admin we have products and orders —suppose all templates on these folders have issues. I would fix products issues on one PR and orders in another one. It's far easier to review changes with this approach, and it's mostly conflict-free.

[kennyadsl]

Ok, considering the feedback received (if linting on existing files needs to happen we need one or more separate PRs) I think this PR is ready to accept reviews :)

[houndci-bot]

Use 1 space after <% instead of 0 space.
Use 1 space before %> instead of 0 space.

[kennyadsl]

I've removed the link to the .rubocop.yml config from the .erblint.yml file since it's still not supported by HoundCI. I've also removed the .erblint.yml file at all since that was the only configuration present. This is now ready to be merged in my opinion.

[jacobherrington]

I'm still completely in support of this getting merged.