Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: create setup.cfg #3181

Closed
wants to merge 1 commit into from
Closed

refactor: create setup.cfg #3181

wants to merge 1 commit into from

Conversation

SauravMaheshkar
Copy link
Contributor

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description

🚨 Issue number

Fixes #2976

📝 What does this PR do?

This PR aims to work on the issues reported in #3016 and #3012. pyproject.toml would lead to a isolated build whereas setup.cfg should not.

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.

@FrankLeeeee
Copy link
Contributor

Hi @SauravMaheshkar , please see #3022 for why setup.cfg is not recommended for this project.

@SauravMaheshkar
Copy link
Contributor Author

Hi @SauravMaheshkar , please see #3022 for why setup.cfg is not recommended for this project.

Oh I didn't know setup.cfg had already been considered as an option.

@SauravMaheshkar SauravMaheshkar deleted the create-setup-cfg branch March 20, 2023 20:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PROPOSAL]: Refactor configuration files
2 participants