Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[revert] recover "[refactor] restructure configuration files (#2977)" #3022

Merged

Conversation

FrankLeeeee
Copy link
Contributor

@FrankLeeeee FrankLeeeee commented Mar 6, 2023

📌 Checklist before creating the PR

  • I have created an issue for this PR for traceability
  • The title follows the standard format: [doc/gemini/tensor/...]: A concise description
  • I have added relevant tags if possible for us to better distinguish different PRs

🚨 Issue number

Link this PR to your issue with words like fixed to automatically close the linked issue upon merge

e.g. fixed #1234, closed #1234, resolved #1234

partial fix for #3012
fixed #3016

📝 What does this PR do?

Summarize your work here.
if you have any plots/diagrams/screenshots/tables, please attach them here.

This PR fixed the PyTorch not found error during installation. The root cause is the usage of pyproject.toml. Despite the fact that pyproject.toml is a newer version of python build tool, it introduces some new features which conflict with our setup.py. The underlying reason for the bug is that pyproject.toml will execute python build in an isolated environment. As a result, PyTorch cannot be found in this isolated environment, leading to installation error when CUDA_EXT=1 is provided.

There is no easy solution to fix this according to pypa/pip#6144. Thus, it might be just good to revert this commit.

Since #3017 is related to pyproject.toml, I will just close #3017 .

💥 Checklist before requesting a review

  • I have linked my PR to an issue (instruction)
  • My issue clearly describes the problem/feature/proposal, with diagrams/charts/table/code if possible
  • I have performed a self-review of my code
  • I have added thorough tests.
  • I have added docstrings for all the functions/methods I implemented

⭐️ Do you enjoy contributing to Colossal-AI?

  • 🌝 Yes, I do.
  • 🌚 No, I don't.

Tell us more if you don't enjoy contributing to Colossal-AI.

@FrankLeeeee FrankLeeeee merged commit 2e427dd into hpcaitech:main Mar 7, 2023
@FrankLeeeee FrankLeeeee deleted the hotfix/setup-torch-not-found branch March 7, 2023 05:33
@FrankLeeeee FrankLeeeee mentioned this pull request Mar 20, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Pre-commit configuration is not compatible with pyproject.toml
2 participants