Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement WebSocket client #93

Merged
merged 43 commits into from
Mar 20, 2022
Merged

Implement WebSocket client #93

merged 43 commits into from
Mar 20, 2022

Conversation

armanbilge
Copy link
Member

Closes #6.

Tests forthcoming.

@armanbilge
Copy link
Member Author

Ok, this is getting closer. The weirdest issue right now is that the echo web server isn't consistently echoing all the messages. Or at least, they are not being received. Firefox flip-flops between receiving only the first two or all three, whereas Chrome consistently receives only the first one.

@armanbilge
Copy link
Member Author

Update: the problem seems to be the ember websocket echo server I'm running within sbt, since sending to https://echo.websocket.events seems to work perfect. Running an IO within sbt is generally dodgy, of course 😩

@armanbilge
Copy link
Member Author

The problem seems to be with ember server's websocket implementation. Switching to blaze works for now 👍

@armanbilge armanbilge marked this pull request as ready for review January 31, 2022 02:28
@armanbilge
Copy link
Member Author

I'm unable to reproduce the problems with Ember server locally. I tried setting the JVM flag -XX:ActiveProcessorCount=1 to more accurately imitate CI but no dice. Maybe just a weird CI thing, idk 🙃

@armanbilge
Copy link
Member Author

Should be good to go. This adds minimal public API, so there's only room for implementation errors 😆

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement a WebSocket client
1 participant