Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make WSClient and friends public #6005

Merged
merged 2 commits into from
Feb 4, 2022

Conversation

armanbilge
Copy link
Member

@mergify mergify bot added series/0.23 PRs targeting 0.23.x module:client labels Feb 4, 2022
@rossabaker
Copy link
Member

Needs the MiMa exemptions, but 👍.

@armanbilge
Copy link
Member Author

Those seem less than ideal. Like they could all-too-easily filter legit issues due to future changes :(

Copy link
Member

@rossabaker rossabaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think there's much that can be done about the broad exemptions, other than to start MiMaing against 0.23.11, which is also not ideal.

@armanbilge
Copy link
Member Author

start MiMaing against 0.23.11, which is also not ideal.

That's even more dangerous, because MiMa automatically ignore package-private stuff. So if something was public in 0.23.0 and then made package-private in 0.23.1, unless we specifically compare against 0.23.0 we could delete that method without getting any warnings.

But you are right that MiMa exemptions should be tied to specific versions e.g. these filters here should only apply when comparing to artifacts before 0.23.11. From 0.23.11 on there should be a clean slate. I do have some imagination of doing something about this at some point 😆

@rossabaker rossabaker merged commit facb2ff into http4s:series/0.23 Feb 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module:client series/0.23 PRs targeting 0.23.x
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants