map request target to target URI/resource #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in caching
royfielding
reviewed
Mar 19, 2020
royfielding
reviewed
Mar 19, 2020
royfielding
reviewed
Mar 19, 2020
royfielding
reviewed
Mar 19, 2020
royfielding
requested changes
Mar 19, 2020
There was a problem hiding this comment.
This is almost all great except where it veers into redefining request-target as the target URI. We still need to differentiate those in Messaging and in the requirements for OPTIONS and CONNECT. In all other cases, target URI is fine because the text is about normal requests (not applicable to OPTIONS and CONNECT).
punting to a separate issue
... will address separately
|
OK, I've reverted the changes specific to CONNECT and OPTIONS and opened #340 to tackle those separately. |
... until resolution of #340
|
Please review soon, this is likely to rot quickly. Thx. |
|
@reschke @royfielding please review. |
reschke
approved these changes
Apr 27, 2020
royfielding
approved these changes
Apr 27, 2020
triple-underscore
added a commit
to triple-underscore/triple-underscore.github.io
that referenced
this pull request
Apr 29, 2020
httpwg/http-core#343 • Adjust multiple Content-Length handling httpwg/http-core#346 • Rework invalidation definition • Roy's suggestions • grammar httpwg/http-core#353 • Make text body narrower for readability httpwg/http-core#354 • Remove H1-specific connection-related requirements • Roy's feedback httpwg/http-core#316 • map request target to target URI/resource • fix one leftover of "effective request URI" • Adjust anchor names • push note into <aside> and move index entry • sort change log • restore indentation • re-add missing closing brackets • fix change log section title • fix change log • remove semantics HTML too • removing HTML from PR httpwg/http-core#344 • Don't rely on the HTTP/1.1 Messaging specification to define "message" httpwg/http-core#357 • Present If-[none]-Match evaluation more clearly httpwg/http-core#72 • Semantics of If-Match httpwg/http-core#345 • remove ref to close option • remove HTML from PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #259