Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove H1-specific connection-related requirements #354

Merged
merged 4 commits into from
Apr 27, 2020
Merged

Remove H1-specific connection-related requirements #354

merged 4 commits into from
Apr 27, 2020

Conversation

mnot
Copy link
Member

@mnot mnot commented Mar 23, 2020

For #144

@mnot mnot requested review from reschke and royfielding March 23, 2020 05:04
reschke
reschke requested changes Mar 23, 2020
View reviewed changes
Copy link
Contributor

@reschke reschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then we need to move these into Messaging, no?

@mnot
Copy link
Member Author

mnot commented Mar 23, 2020

On a case-by-case basis:

  • "HTTP requirements regarding connection management" is an informative reference to h1-messaging, so it's already there;
  • The requirements for 205 are just a re-statement of existing h1 message framing requirements (and duplicative);
  • The requirement for 408 is a bit odd; it's really just spelling out the implications for being in that state in h1. I don't know why it's a SHOULD.
  • 413 has been refactored so it's not h1 specific, but still applicable to it.

@reschke
Copy link
Contributor

reschke commented Mar 28, 2020

Ack!

@reschke reschke self-requested a review March 28, 2020 09:05
royfielding
royfielding requested changes Apr 2, 2020
View reviewed changes
@mnot mnot requested a review from royfielding April 27, 2020 04:41
@mnot mnot merged commit 77b2cd1 into master Apr 27, 2020
@mnot mnot deleted the mnot-144 branch April 27, 2020 23:11
triple-underscore added a commit to triple-underscore/triple-underscore.github.io that referenced this pull request Apr 29, 2020
@triple-underscore
[http] 各種更新
af24854 
httpwg/http-core#343
• Adjust multiple Content-Length handling

httpwg/http-core#346
• Rework invalidation definition
• Roy's suggestions
• grammar

httpwg/http-core#353
• Make text body narrower for readability

httpwg/http-core#354
• Remove H1-specific connection-related requirements
• Roy's feedback

httpwg/http-core#316
• map request target to target URI/resource
• fix one leftover of "effective request URI"
• Adjust anchor names
• push note into <aside> and move index entry
• sort change log
• restore indentation
• re-add missing closing brackets
• fix change log section title
• fix change log
• remove semantics HTML too
• removing HTML from PR

httpwg/http-core#344
• Don't rely on the HTTP/1.1 Messaging specification to define "message"

httpwg/http-core#357
• Present If-[none]-Match evaluation more clearly

httpwg/http-core#72
• Semantics of If-Match

httpwg/http-core#345
• remove ref to close option
• remove HTML from PR
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reschke reschke reschke approved these changes

@royfielding royfielding royfielding approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mnot @reschke @royfielding