Clean Vagrant+Windows Install #201

dahlbyk · 2016-02-09T05:03:01Z

Here are some miscellaneous changes from getting Vagrant up and running on a clean Windows machine.

.gitattributes for EOL consistency
Remove pwd (for debugging) from postinstall (Windows doesn't like the &&)
Further adjust how postinstall calls bower to be more Windows-friendly - @discorick can you confirm cd ember-app && npm install works as expected if you remove their cache dirs?
Add ~~provision.sh for extra provisiony stuff, starting with adding~~ Puppet exec to add cd /srv/huboard to .bashrc
~~Force downgrade bundler to 1.9.6.~~
- ~~It feels like there should be a better way to do this, but I can't tell exactly where the bundler gem is being installed.~~
- ~~@rauhryan, are you able to fill in background on why newer versions won't work?~~

dahlbyk · 2016-02-09T16:09:23Z

I have also updated https://github.com/huboard/huboard/wiki/Local-Development with more correct/complete instructions (even beyond what @discorick reviewed mid-day): https://github.com/huboard/huboard/wiki/Local-Development/_compare/d8b6c62e89b92c029251c6c1c7913609857caf4b...52ab3eeee097c72688b1ad6b5e4d26612c7c3156

rauhryan · 2016-02-17T23:01:19Z

ember-app/package.json

@@ -11,7 +11,7 @@
    "start": "ember server",
    "build": "ember build",
    "test": "ember test",
-    "postinstall": "pwd && ../node_modules/.bin/bower install"
+    "postinstall": "node ../node_modules/bower/bin/bower install"


I wasn't aware that npm on windows and npm on unix differed in this convention.

This might not work for a heroku deployment

It does, as far as I can tell: https://huboard-rails-pr-201.herokuapp.com/

dahlbyk · 2016-02-18T06:13:58Z

Would appreciate some eyes one this next round of Local Dev updates based on some challenges getting another Windows machine up and running: https://github.com/huboard/huboard/wiki/Local-Development/_compare/52ab3eeee097c72688b1ad6b5e4d26612c7c3156...c8e5cb7b6328054ab0e1ed6518d8fca13e4dd353?short_path=459bc87#diff-459bc87850f2ab005ca4943e7253122c

discorick · 2016-02-19T20:41:16Z

@dahlbyk were you planning on removing the app.json file from source control ?

dahlbyk · 2016-02-19T21:47:16Z

were you planning on removing the app.json file from source control ?

Have to commit it for Heroku per-PR deploy to work. I can revert it here and move to a separate PR for addressing #183 if you'd prefer.

The last thing we need to figure out here is why we still end up with Bundler 1.11.2 after a vagrant up, despite provision.sh being executed with:

gem uninstall --ignore-dependencies --executables --quiet bundler
gem install bundler --version 1.9.6 --no-ri --no-rdoc

If I vagrant ssh into the box and run the above I end up using the correct version, and bundle install works as expected. Any ideas?

Finally, setting my bundler issues aside: why doesn't vagrant provision handle the bundle install?

dahlbyk · 2016-02-20T20:47:58Z

The last thing we need to figure out here is why we still end up with Bundler 1.11.2 after a vagrant up

Alright, so within provision.sh I get:

$ gem env
RubyGems Environment:
  - RUBYGEMS VERSION: 1.8.23
  - RUBY VERSION: 1.9.3 (2013-11-22 patchlevel 484) [x86_64-linux]
  - INSTALLATION DIRECTORY: /var/lib/gems/1.9.1
  - RUBY EXECUTABLE: /usr/bin/ruby1.9.1
  - EXECUTABLE DIRECTORY: /usr/local/bin
  - RUBYGEMS PLATFORMS:
    - ruby
    - x86_64-linux
  - GEM PATHS:
     - /var/lib/gems/1.9.1
     - /root/.gem/ruby/1.9.1
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :benchmark => false
     - :backtrace => false
     - :bulk_threshold => 1000
  - REMOTE SOURCES:
     - http://rubygems.org/
$ gem list
bundler (1.9.6)
semver (1.0.1)

While vagrant ssh'd:

vagrant@localhost:/srv/huboard$ gem env
RubyGems Environment:
  - RUBYGEMS VERSION: 2.4.5
  - RUBY VERSION: 2.2.1 (2015-02-26 patchlevel 85) [x86_64-linux]
  - INSTALLATION DIRECTORY: /home/vagrant/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0
  - RUBY EXECUTABLE: /home/vagrant/.rbenv/versions/2.2.1/bin/ruby
  - EXECUTABLE DIRECTORY: /home/vagrant/.rbenv/versions/2.2.1/bin
  - SPEC CACHE DIRECTORY: /home/vagrant/.gem/specs
  - SYSTEM CONFIGURATION DIRECTORY: /home/vagrant/.rbenv/versions/2.2.1/etc
  - RUBYGEMS PLATFORMS:
    - ruby
    - x86_64-linux
  - GEM PATHS:
     - /home/vagrant/.rbenv/versions/2.2.1/lib/ruby/gems/2.2.0
     - /home/vagrant/.gem/ruby/2.2.0
  - GEM CONFIGURATION:
     - :update_sources => true
     - :verbose => true
     - :backtrace => false
     - :bulk_threshold => 1000
  - REMOTE SOURCES:
     - https://rubygems.org/
  - SHELL PATH:
     - /home/vagrant/.rbenv/versions/2.2.1/bin
     - /home/vagrant/.rbenv/libexec
     - /home/vagrant/.rbenv/plugins/ruby-build/bin
     - /home/vagrant/.rbenv/shims
     - /home/vagrant/.rbenv/bin
     - /usr/local/node/node-default/bin
     - /usr/local/sbin
     - /usr/local/bin
     - /usr/sbin
     - /usr/bin
     - /sbin
     - /bin
     - /usr/games
     - /usr/local/games
vagrant@localhost:/srv/huboard$ gem list

*** LOCAL GEMS ***

bigdecimal (1.2.6)
bundler (1.11.2)
io-console (0.4.3)
json (1.8.1)
minitest (5.4.3)
power_assert (0.2.2)
psych (2.0.8)
rake (10.4.2)
rdoc (4.2.0)
test-unit (3.0.8)

So my current hack won't work. Any ideas?

dahlbyk · 2016-02-23T06:28:00Z

So it looks like bundler is being installed with rbenv, which is interesting because I stumbled on huboard/puppet-rbenv@dedcf98. @rauhryan any ideas?

discorick · 2016-02-25T21:14:56Z

@dahlbyk are you asking how to get bundler to install on provision ?

dahlbyk · 2016-02-26T06:06:46Z

Alright, I've moved the commits related to #183 over into #214 so we can focus on the Vagrant and Windows story. After #213, we're tentatively cool with Bundler > 1.10, so I've dropped my misguided attempts to downgrade to 1.9.6.

This also commits the much-maligned BUNDLED WITH. That change will need to be reverted in enterprise until we can figure out how to upgrade Bundler in HB:E.

are you asking how to get bundler to install on provision ?

I was asking this, yes, but we can defer that discussion.

dahlbyk · 2016-02-26T06:18:31Z

I've deployed latest here to https://huboard-rails.herokuapp.com/ for a sanity check.

discorick · 2016-02-26T17:44:32Z

provision.sh

@@ -0,0 +1,2 @@
+# Switch to /srv/huboard on login
+echo "cd /srv/huboard" >> /home/vagrant/.bashrc


Lets pair together on moving this to puppet, its probably best to keep our provisioning unified.

discorick · 2016-02-26T17:45:35Z

As we move provision.sh to puppet, we can also instruct puppet to run bundle install

dahlbyk · 2016-02-27T19:37:29Z

puppet/manifests/base.pp

+  exec { "echo 'cd /srv/huboard' >> .bashrc":
+    cwd    => "/home/vagrant",
+    path   => "/usr/bin:/usr/sbin:/bin",
+    unless => "grep -q '^cd /srv/huboard$' .bashrc"


Lets pair together on moving this to puppet, its probably best to keep our provisioning unified.

Better?

dahlbyk · 2016-02-29T15:16:41Z

we can also instruct puppet to run bundle install

I tried a bunch of iterations along the lines of:

diff --git a/puppet/manifests/base.pp b/puppet/manifests/base.pp
index 5fee4ee..4663669 100644
--- a/puppet/manifests/base.pp
+++ b/puppet/manifests/base.pp
@@ -13,6 +13,12 @@ package {
     ruby_version => "2.2.1",
   }

+  exec { 'bundle install':
+    cwd  => "/home/vagrant",
+    path => "/usr/bin:/usr/sbin:/bin:/home/vagrant/.rbenv/bin:/home/vagrant/.rbenv/shims",
+    require => Class['ruby_install']
+  }
+
   class { 'wkhtmltox':
     ensure => 'present' 
   }

I tried rbenv shell 2.2.1 && bundle install, I tried dumping rbenv versions in its own step (only version shown is "system"). I am confused.

Here's the full Vagrant/Puppet debug log for ruby_install and bundle install:

==> default: Notice: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Rbenv::Plugin::Rubybuild[rbenv::rubybuild::vagrant]/Rbenv::Plugin[rbenv::plugin::rubybuild::vagrant]/File[rbenv::plugins vagrant]/ensure: created
==> default: Debug: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Rbenv::Plugin::Rubybuild[rbenv::rubybuild::vagrant]/Rbenv::Plugin[rbenv::plugin::rubybuild::vagrant]/File[rbenv::plugins vagrant]: The container Rbenv::Plugin[rbenv::plugin::rubybuild::vagrant] will propagate my refresh event
==> default: Debug: Exec[rbenv::plugin::checkout vagrant ruby-build](provider=posix): Executing 'git clone git://github.com/sstephenson/ruby-build.git /home/vagrant/.rbenv/plugins/ruby-build'
==> default: Debug: Executing 'git clone git://github.com/sstephenson/ruby-build.git /home/vagrant/.rbenv/plugins/ruby-build'
==> default: Notice: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Rbenv::Plugin::Rubybuild[rbenv::rubybuild::vagrant]/Rbenv::Plugin[rbenv::plugin::rubybuild::vagrant]/Exec[rbenv::plugin::checkout vagrant ruby-build]/returns: executed successfully
==> default: Debug: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Rbenv::Plugin::Rubybuild[rbenv::rubybuild::vagrant]/Rbenv::Plugin[rbenv::plugin::rubybuild::vagrant]/Exec[rbenv::plugin::checkout vagrant ruby-build]: The container Rbenv::Plugin[rbenv::plugin::rubybuild::vagrant] will propagate my refresh event
==> default: Debug: Rbenv::Plugin[rbenv::plugin::rubybuild::vagrant]: The container Rbenv::Plugin::Rubybuild[rbenv::rubybuild::vagrant] will propagate my refresh event
==> default: Debug: Rbenv::Plugin::Rubybuild[rbenv::rubybuild::vagrant]: The container Rbenv::Compile[vagrant/2.2.1] will propagate my refresh event
==> default: Debug: Exec[rbenv::compile vagrant 2.2.1](provider=posix): Executing 'rbenv install 2.2.1 && touch /home/vagrant/.rbenv/.rehash'
==> default: Debug: Executing 'rbenv install 2.2.1 && touch /home/vagrant/.rbenv/.rehash'
==> default: Notice: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Exec[rbenv::compile vagrant 2.2.1]/returns: executed successfully
==> default: Debug: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Exec[rbenv::compile vagrant 2.2.1]: The container Rbenv::Compile[vagrant/2.2.1] will propagate my refresh event
==> default: Debug: Executing '/bin/su - vagrant -c RBENV_VERSION=2.2.1 /home/vagrant/.rbenv/versions/2.2.1/bin/gem list --local bundler$'
==> default: Debug: Executing '/bin/su - vagrant -c RBENV_VERSION=2.2.1 /home/vagrant/.rbenv/versions/2.2.1/bin/gem install --no-rdoc --no-ri bundler'
==> default: Notice: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Rbenv::Gem[rbenv::bundler vagrant 2.2.1]/Rbenvgem[vagrant/2.2.1/bundler/present]/ensure: created
==> default: Debug: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Rbenv::Gem[rbenv::bundler vagrant 2.2.1]/Rbenvgem[vagrant/2.2.1/bundler/present]: The container Rbenv::Gem[rbenv::bundler vagrant 2.2.1] will propagate my refresh event
==> default: Debug: Rbenv::Gem[rbenv::bundler vagrant 2.2.1]: The container Rbenv::Compile[vagrant/2.2.1] will propagate my refresh event
==> default: Debug: Exec[rbenv::rehash vagrant 2.2.1](provider=posix): Executing check '[ -e '/home/vagrant/.rbenv/.rehash' ]'
==> default: Debug: Executing '[ -e '/home/vagrant/.rbenv/.rehash' ]'
==> default: Debug: Exec[rbenv::rehash vagrant 2.2.1](provider=posix): Executing 'rbenv rehash && rm -f /home/vagrant/.rbenv/.rehash'
==> default: Debug: Executing 'rbenv rehash && rm -f /home/vagrant/.rbenv/.rehash'
==> default: Notice: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Exec[rbenv::rehash vagrant 2.2.1]/returns:executed successfully
==> default: Debug: /Stage[main]/Ruby_install/Rbenv::Compile[vagrant/2.2.1]/Exec[rbenv::rehash vagrant 2.2.1]: The container Rbenv::Compile[vagrant/2.2.1] will propagate my refresh event
==> default: Debug: Rbenv::Compile[vagrant/2.2.1]: The container Class[Ruby_install] will propagate my refresh event
==> default: Debug: Class[Ruby_install]: The container Stage[main] will propagate my refresh event
==> default: Debug: Exec[bundle install](provider=posix): Executing 'bundle install'
==> default: Debug: Executing 'bundle install'
==> default: Error: rbenv: bundle: command not found
==> default:
==> default: The `bundle' command exists in these Ruby versions:
==> default:   2.2.1
==> default:
==> default: Error: /Stage[main]/Main/Exec[bundle install]/returns: change from notrun to 0 failed: rbenv: bundle: command not found
==> default:
==> default: The `bundle' command exists in these Ruby versions:
==> default:   2.2.1

discorick · 2016-03-03T17:14:43Z

Let's punt on adding bundler to this PR, and have a more general 'update puppet manifest' PR at a later date

Clean Vagrant+Windows Install

dahlbyk force-pushed the clean-install branch 2 times, most recently from a113463 to 4f2c2c5 Compare February 9, 2016 05:44

dahlbyk requested a deployment to huboard-rails-pr-201 February 9, 2016 06:58 Pending

dahlbyk deployed to huboard-rails-pr-201 February 9, 2016 06:58 Active

dahlbyk mentioned this pull request Feb 9, 2016

Continuous Delivery per Pull Request on Heroku #183

Closed

dahlbyk deployed to huboard-rails-pr-201 February 9, 2016 17:57 Active

rauhryan reviewed Feb 17, 2016
View reviewed changes

dahlbyk deployed to huboard-rails-pr-201 February 18, 2016 20:54 Active

dahlbyk mentioned this pull request Feb 25, 2016

Resolves gemspec deprecation warnings on the Rails engine and Faye Extensions #213

Merged

dahlbyk had a problem deploying to huboard-rails-pr-201 February 26, 2016 02:42 Failure

dahlbyk added 4 commits February 25, 2016 21:57

Add .gitattributes to enforce normalization on Windows

82c8d91

Remove debugging pwd from postinstall

7fedf95

Fix postinstall on Windows

ab89074

Auto-cd /srv/huboard

b739f12

dahlbyk force-pushed the clean-install branch from ec26b35 to 35e6144 Compare February 26, 2016 02:58

dahlbyk deployed to huboard-rails-pr-201 February 26, 2016 02:58 Active

dahlbyk deployed to huboard-rails-pr-201 February 26, 2016 03:50 Active

dahlbyk deployed to huboard-rails-pr-201 February 26, 2016 04:18 Active

dahlbyk deployed to huboard-rails-pr-201 February 26, 2016 04:30 Active

dahlbyk deployed to huboard-rails-pr-201 February 26, 2016 04:51 Active

dahlbyk force-pushed the clean-install branch from b001852 to 4dccbcf Compare February 26, 2016 04:51

dahlbyk deployed to huboard-rails-pr-201 February 26, 2016 04:51 Active

dahlbyk deployed to huboard-rails-pr-201 February 26, 2016 05:06 Active

dahlbyk mentioned this pull request Feb 26, 2016

Implement Heroku Review Apps #214

Merged

3 tasks

dahlbyk and others added 3 commits February 26, 2016 00:56

Execute provision.sh last

078bee6

Add commented VirtualBox debugging tip

03ad123

BUNDLED WITH 1.11.2

e5682d3

dahlbyk force-pushed the clean-install branch from 4dccbcf to e5682d3 Compare February 26, 2016 05:56

discorick reviewed Feb 26, 2016
View reviewed changes

Use Puppet exec instead of separate provision.sh

2cc6cfd

dahlbyk reviewed Feb 27, 2016
View reviewed changes

dahlbyk added the 3 - In Review label Feb 29, 2016

discorick added a commit that referenced this pull request Mar 3, 2016

Merge pull request #201 from huboard/clean-install

92bda6c

Clean Vagrant+Windows Install

discorick merged commit 92bda6c into master Mar 3, 2016

discorick deleted the clean-install branch March 3, 2016 17:14

dahlbyk mentioned this pull request May 15, 2016

Fix gem install mailcatcher #300

Merged

3 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Clean Vagrant+Windows Install #201

Clean Vagrant+Windows Install #201

dahlbyk commented Feb 9, 2016

dahlbyk commented Feb 9, 2016

rauhryan Feb 17, 2016

dahlbyk Feb 18, 2016

dahlbyk commented Feb 18, 2016

discorick commented Feb 19, 2016

dahlbyk commented Feb 19, 2016

dahlbyk commented Feb 20, 2016

dahlbyk commented Feb 23, 2016

discorick commented Feb 25, 2016

dahlbyk commented Feb 26, 2016

dahlbyk commented Feb 26, 2016

discorick Feb 26, 2016

discorick commented Feb 26, 2016

dahlbyk Feb 27, 2016

dahlbyk commented Feb 29, 2016

discorick commented Mar 3, 2016

		@@ -0,0 +1,2 @@
		# Switch to /srv/huboard on login
		echo "cd /srv/huboard" >> /home/vagrant/.bashrc

Clean Vagrant+Windows Install #201

Clean Vagrant+Windows Install #201

Conversation

dahlbyk commented Feb 9, 2016

dahlbyk commented Feb 9, 2016

rauhryan Feb 17, 2016

Choose a reason for hiding this comment

dahlbyk Feb 18, 2016

Choose a reason for hiding this comment

dahlbyk commented Feb 18, 2016

discorick commented Feb 19, 2016

dahlbyk commented Feb 19, 2016

dahlbyk commented Feb 20, 2016

dahlbyk commented Feb 23, 2016

discorick commented Feb 25, 2016

dahlbyk commented Feb 26, 2016

dahlbyk commented Feb 26, 2016

discorick Feb 26, 2016

Choose a reason for hiding this comment

discorick commented Feb 26, 2016

dahlbyk Feb 27, 2016

Choose a reason for hiding this comment

dahlbyk commented Feb 29, 2016

discorick commented Mar 3, 2016