Resolves gemspec deprecation warnings on the Rails engine and Faye Extensions #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| s.homepage = "TODO" | ||
| s.summary = "TODO: Summary of Saas." | ||
| s.description = "TODO: Description of Saas." | ||
| s.homepage = "https://github.com/huboard/huboard-web/vender/gems/faye_extensions" |
There was a problem hiding this comment.
|
I'm going to pull this down with #201 and see if a clean |
| s.homepage = "TODO" | ||
| s.summary = "TODO: Summary of Saas." | ||
| s.description = "TODO: Description of Saas." | ||
| s.homepage = "https://github.com/huboard/huboard-web/tree/master/vendor/gems/faye_extensions " |
|
Good call, if that fixes it ill throw my hat (I dont have a hat...) |
|
Looks pretty harmeless
|
?
I don't remember 100% what I was seeing before, but everything seems to be 🆒 locally for me. You might try a clean |
dahlbyk
added a commit
that referenced
this pull request
Feb 25, 2016
…ation_warnings Resolves gemspec deprecation warnings on the Rails engine and Faye Extensions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was blocking our deployments to heroku as of this build pack deploy: heroku/heroku-buildpack-ruby#461
The deprecations look something like this:
On deploy they would literally prevent
analytics-rubyfrom the rails enginegemspecfrom installing.Take a look at the diff to see the offending code, pretty weird that
'TODO'strings would cause such a fuss.