-
Notifications
You must be signed in to change notification settings - Fork 82
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make workers' errors derive from WorkerError #772
Make workers' errors derive from WorkerError #772
Conversation
The documentation is not available anymore as the PR was closed or merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It was incoherent
Apparently there is (again) a connectivity issue with http://azure.archive.ubuntu.com mirrors... |
OK, Azure seems to work again. And there is an issue with the types: the signatures are not exactly the same |
@severo, I have created Alternatively I could have renamed What do you think is more clear? |
The CI error is unrelated to this PR: https://github.com/huggingface/datasets-server/actions/runs/4105164627/jobs/7081642597
See: |
I think it's ok, now |
Make workers' errors derive from
WorkerError
, instead of parentCustomError
.