Fix CI mypy error: "WorkerFactory" has no attribute "app_config"

[albertvillanova]

Fix type checking on WorkerLoop.loop method, when tryin to access the worker_factory's attribute app_config.

This PR fixes an issue introduced by:

• Use hub-ci locally #774

src/datasets_based/worker_loop.py:100: error: "WorkerFactory" has no attribute "app_config"

[HuggingFaceDocBuilderDev]

The documentation is not available anymore as the PR was closed or merged.

[albertvillanova]

Please note this is a quick fix so that our CI is working again.

We should think, as privately discussed with @severo, about the class hierarchy with the DatasetBased... intermediate level...

Maybe, we could use BaseWorkerFactory to define the interface, and rename DatasetBasedWorkerFactory to WorkerFactory...

[albertvillanova]

The root error raised by mypy is that WorkerLoop.loop() is trying to get the attribute self.worker_factory.app_config on an instance of WorkerFactory, whereas the attribute app_config is defined only for its child DatasetBasedWorkerFactory(WorkerFactory).

[albertvillanova]

Another approach would be to define the attribute app_config in the interface WorkerFactory...

[severo]

The bug has been introduced by:

https://github.com/huggingface/datasets-server/pull/774/files#diff-4326852d55eab85b019c702a4579f696cb429aaf13586d8e3a1824581f8c9e34R100

@lhoestq I would vote to remove this log or move it elsewhere because we will soon implement #737, which will allow a worker loop to manage various endpoints.

[albertvillanova]

I am making the corresponding changes and you can review them.

[codecov-commenter]

Codecov Report

Base: 91.76% // Head: 91.80% // Increases project coverage by +0.04% 🎉

Coverage data is based on head (0cc2bae) compared to base (2e920f6).
Patch has no changes to coverable lines.

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #778      +/-   ##
==========================================
+ Coverage   91.76%   91.80%   +0.04%     
==========================================
  Files          33       33              
  Lines        2246     2245       -1     
==========================================
  Hits         2061     2061              
+ Misses        185      184       -1     

Flag	Coverage Δ
workers_datasets_based	91.80% <ø> (+0.04%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...s/datasets_based/src/datasets_based/worker_loop.py	47.50% <ø> (+0.58%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

[lhoestq]

thanks - it's fine to remove it

[severo]

Thanks!!

[severo]

(I'm merging to fix the CI on other PRs)