Use hub-ci locally #774
Merged
Use hub-ci locally #774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The documentation is not available anymore as the PR was closed or merged. |
severo
approved these changes
Feb 6, 2023
| @@ -97,6 +98,8 @@ def sleep(self) -> None: | |||
| time.sleep(duration) | |||
|
|
|||
| def loop(self) -> None: | |||
| if os.environ.get("HF_ENDPOINT"): | |||
There was a problem hiding this comment.
We don't access the os environment variables outside of the config.py files. Do you think it's possible to keep on with this practice and move the log there?
There was a problem hiding this comment.
I kept the logging here and got the endpoint value from worker_factory.app_config.common
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I switched the HF endpoint to the hub-ci one and added the corresponding tokens, and fixed the docker-compose to use the right base.
Now the local dev environment from
make dev-startworks correctly.Close #765