Fix cos_sin device issue in Falcon model
#26448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ydshieh
commented
Sep 27, 2023
Comment on lines
133
to
136
| # the cached tensors need to update their devices (for example, after we change the model's device) | ||
| if device != self.cos_cached: | ||
| self.cos_cached = self.cos_cached.to(device) | ||
| self.sin_cached = self.sin_cached.to(device) |
There was a problem hiding this comment.
without this, we have problems when switching a model device
There was a problem hiding this comment.
Shouldn't this be a check on the device of self.cos_cached rather than on the tensor?
There was a problem hiding this comment.
Yes, don't know why I made such mistake (as it works on the code snippet I am using 😅 sorry). You saved me!
|
The documentation is not available anymore as the PR was closed or merged. |
ydshieh
commented
Sep 28, 2023
Comment on lines
+134
to
+135
| self.cos_cached = self.cos_cached.to(device) | ||
| self.sin_cached = self.sin_cached.to(device) |
There was a problem hiding this comment.
I removed the check of device. As we can't compare device (given by a tensor) with a string directly.
If it is on the same device (inferred by torch itself), there won't be any operation performed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
We should update the device accordingly. See the comments along the changes.
So far, running the model on GPU, then change model to CPU and running CPU inputs, the cached tensors (like
cos_cached) will be on GPU and fail to run with CPU tensors.