Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cos_sin device issue in Falcon model #26448

Merged
merged 3 commits into from
Sep 28, 2023
Merged

Fix cos_sin device issue in Falcon model #26448

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ac9ae23
fix
ydshieh Sep 27, 2023
24ef7af
fix
ydshieh Sep 27, 2023
1a4f624
fix
ydshieh Sep 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/transformers/models/falcon/modeling_falcon.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -129,6 +129,12 @@ def cos_sin(
total_length = seq_len + past_key_values_length
if total_length > self.seq_len_cached:
self._set_cos_sin_cache(total_length, device, dtype)

# the cached tensors need to update their devices (for example, after we change the model's device)
if device != self.cos_cached:
self.cos_cached = self.cos_cached.to(device)
self.sin_cached = self.sin_cached.to(device)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

without this, we have problems when switching a model device

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this be a check on the device of self.cos_cached rather than on the tensor?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, don't know why I made such mistake (as it works on the code snippet I am using 😅 sorry). You saved me!


# Gather cos, sin at the designated position ids
cos = self.cos_cached.squeeze(0)[position_ids] # [bs, seq_len, dim]
sin = self.sin_cached.squeeze(0)[position_ids] # [bs, seq_len, dim]
Expand Down