fixes #32 and fixes #51 #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| * @param string $path Path relative to the home URL. Blank string if no path is specified. | ||
| * @return string Mangled Content URL | ||
| */ | ||
| function mangle_content_url( $url, $path) { |
|
Sorry for the overcommenting here, kind of stream-of-consciousness. Thanks for the PR! Do we need the |
|
I swear I tried using that function first, and there was some reason it didn't work with the other filters. I do agree reading it out of context here that it appears they should be able to merge IF we make the 3rd param optional. Oh, that was it, content_url filter only passes 2 params and causes an error when you try to use this function to filter. I can just set it to null by default. I'll try that. |
…to work with 2 params
|
Yup, you were right, I removed the function, corrected everything and tested it. |
Merge Primary domain redirection
Fixed alignment
Update with original repo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.