First batch of suggested edits #1
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also a couple of comments in the file using-alti-scli and private-packages
mikelittle
changed the title
owaincuvelier
approved these changes
Jan 15, 2025
| `auth.json` is prevented from being accessed directly via the servers, so this won't be exposed publicly. | ||
|
|
||
| [OWAIN, Should this mention secrets now we have them? - ie generate the auth.json as part of the build script tso it is not committed to the repo?] |
There was a problem hiding this comment.
can remove this note. We can create a new issue to write a page on secrets!
There was a problem hiding this comment.
Just noting the auth.json case is explicitly part of the examples on https://docs.altis-dxp.com/cloud/build-scripts/private-dependencies/
owaincuvelier
requested changes
Jan 24, 2025
| `auth.json` is prevented from being accessed directly via the servers, so this won't be exposed publicly. | ||
|
|
||
| [OWAIN, Should this mention secrets now we have them? - ie generate the auth.json as part of the build script tso it is not committed to the repo?] |
There was a problem hiding this comment.
can you remove this note addressed to me?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some suggestions for the FAQ pages.
There are a couple of questions in
private-packages.mdusing-altis-cli.md