-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
First batch of suggested edits #1
Open
mikelittle
wants to merge
3
commits into
master
Choose a base branch
from
suggested-edits
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,19 +1,29 @@ | ||
# ElasticSearch Index: Error: An index is already occurring. Try again later. | ||
|
||
If you recieve the error `ElasticSearch Index: Error: An index is already occurring. Try again later. ` when performing an ElasticSearch reindex, it's possible the indexing flag for an in-progress index has got stuck. The resulting error will occur: | ||
If you receive the error `ElasticSearch Index: Error: An index is already occurring. Try again later. ` when performing an ElasticSearch reindex, it's possible the indexing flag for an in-progress index has got stuck. The resulting error will occur: | ||
|
||
``` | ||
Error: An index is already occurring. Try again later. | ||
``` | ||
|
||
In such a case, you can clear the flag by running the following: | ||
|
||
``` | ||
wp elasticpress clear-sync | ||
``` | ||
Alternatively, if the above doesn't resolve the issue, it can also be stuck in a [WordPress pransient](https://developer.wordpress.org/apis/transients/). If so you can try the following: | ||
|
||
Alternatively, if the above doesn't resolve the issue, it can also be stuck | ||
in a [WordPress pransient](https://developer.wordpress.org/apis/transients/). If so, you can try the following: | ||
|
||
``` | ||
wp transient delete ep_wpcli_sync --network | ||
``` | ||
|
||
Occasionally this value can also be stored in the object cache. Flushing the object cache should be performed with caution when working on live environments. | ||
You can flush your object cache via a new CLI Session, see: https://docs.altis-dxp.com/cloud/dashboard/cli/ and run the following: | ||
|
||
``` | ||
wp cache flush | ||
``` | ||
``` | ||
|
||
**Note that flushing the object cache can have a significant impact on performance, so we recommend you only do this when necessary.** |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -10,4 +10,6 @@ composer config --auth http-basic.my.yoast.com token {token} | |
|
||
You should see a `auth.json` file in the project's directory - you can commit this, and it should authenticate correctly in the build. | ||
|
||
`auth.json` is prevented from being accessed directly via the servers, so this won't be exposed publicly. | ||
`auth.json` is prevented from being accessed directly via the servers, so this won't be exposed publicly. | ||
|
||
[OWAIN, Should this mention secrets now we have them? - ie generate the auth.json as part of the build script tso it is not committed to the repo?] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. can you remove this note addressed to me? |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove this note. We can create a new issue to write a page on secrets!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just noting the auth.json case is explicitly part of the examples on https://docs.altis-dxp.com/cloud/build-scripts/private-dependencies/