Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift 4.2 Support #108

Closed
Blackjacx opened this issue Sep 12, 2018 · 10 comments · Fixed by #110
Closed

Swift 4.2 Support #108

Blackjacx opened this issue Sep 12, 2018 · 10 comments · Fixed by #110
Assignees
Labels
enhancement New feature or request

Comments

@Blackjacx
Copy link
Contributor

Hey there! Just configured everything for Swift 4.2 but unfortunately SwiftEntryKit and/or QuickLayout does not support it yet. A fix is welcomed :-)

@huri000
Copy link
Owner

huri000 commented Sep 13, 2018

Hi! You’re right. Unfortunately I won’t be able to make that adjustment within the next 2 weeks (I won’t be near my mac).
I’ll handle it right after Sep 26. In the meantime, you can fork those projects and make the modifications. 🙂

@aaronbrethorst aaronbrethorst mentioned this issue Sep 21, 2018
@huri000
Copy link
Owner

huri000 commented Sep 28, 2018

Hi - until SwiftEntryKit and QuickLayout support Swift 4.2 you can add the following in your Podfile in order to make the project run smoothly.

swift_4_2_pod_targets = ['SwiftEntryKit', 'QuickLayout']
post_install do | installer |
    installer.pods_project.targets.each do |target|
        if swift_4_2_pod_targets.include?(target.name)
            target.build_configurations.each do |config|
                config.build_settings['SWIFT_VERSION'] = '4.2'
            end
        end
    end
end

@huri000 huri000 reopened this Sep 28, 2018
@Kaspik
Copy link

Kaspik commented Sep 28, 2018

So it looks like SwiftEntryKit is ready and the last thing is QuickLayout - QLCompatibility.swift. Anything we can help you with or are you already on it today @huri000 ? :)

@huri000
Copy link
Owner

huri000 commented Sep 28, 2018

Actually, QuickLayout pod should compile as well using that Podfile patch from above.
I think that later today or tomorrow I'll be able to migrate both QuickLayout & SwiftEntryKit to Swift 4.2.

@Kaspik
Copy link

Kaspik commented Sep 28, 2018

Yeah, it does, I just wanted to say that it looks like it's already 4.2 compatible except this one file - so if you wanna help with PR or if you are on it and it would be waste of time. :)

@huri000
Copy link
Owner

huri000 commented Sep 28, 2018

Thanks, @Kaspik! I'm on it :-)
I'll keep you posted on this thread.

@huri000 huri000 self-assigned this Sep 28, 2018
@huri000 huri000 added the enhancement New feature or request label Sep 28, 2018
@huri000
Copy link
Owner

huri000 commented Sep 28, 2018

@Kaspik, @Blackjacx, SwiftEntryKit supports Swift 4.2 natively as of version 0.8.0.
Cheers! 🎉

@huri000 huri000 closed this as completed Sep 28, 2018
@huri000
Copy link
Owner

huri000 commented Sep 28, 2018

Also - please note that additional changes must be made in order to adapt to 0.7.0 and above. See CHANGELOG for more information.

@Kaspik
Copy link

Kaspik commented Sep 28, 2018

Thank you! I was already using 0.7 so there are just good news for me :)

@huri000
Copy link
Owner

huri000 commented Oct 1, 2018

Hi - I've made a necessary fix to the swift version for QuickLayout's and SwiftEntryKit's podspecs. Please use 0.8.1 instead of 0.8.0. This fix enabled developers to use Xcode 10 and lower than 4.2 swift version of the project's targets without specifying this in their Podfile (quite dirty approach that was). ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants