Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to Swift 4.2 #115

Merged
merged 5 commits into from
Sep 28, 2018
Merged

Migrate to Swift 4.2 #115

merged 5 commits into from
Sep 28, 2018

Conversation

huri000
Copy link
Owner

@huri000 huri000 commented Sep 28, 2018

Issue Link 🔗

Swift 4.2 Support #108

Goals 🥅

Migrate to Swift 4.2 Wholy including CocoaPods, Carthage, Example project (test), Quick Layout new version.

@codecov
Copy link

codecov bot commented Sep 28, 2018

Codecov Report

Merging #115 into master will increase coverage by 0.02%.
The diff coverage is 22.72%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #115      +/-   ##
=========================================
+ Coverage    4.18%   4.21%   +0.02%     
=========================================
  Files          56      56              
  Lines        2102    1969     -133     
=========================================
- Hits           88      83       -5     
+ Misses       2014    1886     -128
Impacted Files Coverage Δ
...EntryAttributes/EKAttributes+BackgroundStyle.swift 0% <ø> (ø) ⬆️
Source/Infra/EKRootViewController.swift 0% <0%> (ø) ⬆️
Source/Infra/EKContentView.swift 0% <0%> (ø) ⬆️
...ssageViews/Notes/EKProcessingNoteMessageView.swift 0% <0%> (ø) ⬆️
Source/Model/EKProperty.swift 0% <0%> (ø) ⬆️
...e/MessageViews/MessagesUtils/EKButtonBarView.swift 0% <0%> (ø) ⬆️
.../EntryAttributes/EKAttributes+HapticFeedback.swift 0% <0%> (ø) ⬆️
...del/EntryAttributes/EKAttributes+Validations.swift 90% <100%> (ø) ⬆️
...del/EntryAttributes/EKAttributes+WindowLevel.swift 100% <100%> (ø) ⬆️
...odel/EntryAttributes/EKAttributes+Precedence.swift 53.12% <0%> (-4.77%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b4bbb67...a2dc299. Read the comment docs.

@huri000 huri000 merged commit 49c0a14 into master Sep 28, 2018
@huri000 huri000 deleted the feature/swift-version branch September 28, 2018 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant