Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cannot locate buttons for UI tests #222

Closed
alexcurylo opened this issue Aug 20, 2019 · 1 comment
Closed

Cannot locate buttons for UI tests #222

alexcurylo opened this issue Aug 20, 2019 · 1 comment

Comments

@alexcurylo
Copy link

alexcurylo commented Aug 20, 2019 •
edited
Loading

Describe the bug

SwiftEntryKit dialogs cannot be recorded in UI tests

To Reproduce

Steps to reproduce the behavior:

  1. Record a UI test with Xcode
  2. Tap a SwiftEntryKit button
  3. Recording aborts with an error that no control could be found

However, it turns out that if we do script access to labels and buttons it'll work, so this is just somewhat of an inconvenience. But exposing accessibilityIdentifier would be a nice feature to add!

Expected behavior

Ideally, the accessibilityIdentifier should be settable in title, button, etc. attributes so we can script tests that don't depend on translations.

Screenshots
If applicable, add screenshots to help explain your problem.

iPhone (please complete the following information):

  • Device: All
  • iOS Version: All
  • Xcode Version: 10.3
  • Dependency Manager Version: CocoaPods 1.7.5
  • SwiftEntryKit Release # 1.1.2

Additional context
Add any other context about the problem here.

Screenshots / Video Links
huri000 added a commit that referenced this issue Sep 1, 2020
@huri000
#222 fix accessibility for buttons. #294 set accessibilityViewIsModal…
ed78457 
… for EKWindow instance
@huri000 huri000 mentioned this issue Sep 1, 2020
Merged
huri000 added a commit that referenced this issue Sep 1, 2020
@huri000
feature(Accessibility): add accessibility capabilities to button. mak…
76fd46c 
…e every `EKWindow` instance a modal for accessibility (#304)

* update README

* update README

* update README

* #222 fix accessibility for buttons. #294 set accessibilityViewIsModal for EKWindow instance
huri000 added a commit that referenced this issue Sep 1, 2020
@huri000
release(1.2.5): additional accessibility support (#305)
ccc71fd 
* update README

* update README

* update README

* #222 fix accessibility for buttons. #294 set accessibilityViewIsModal for EKWindow instance

* bump to 1.2.5
@huri000
Copy link
Owner

huri000 commented Sep 1, 2020 •
edited
Loading

Accessibility is supported for buttons as well (release 1.2.5), and some fine tunes were made. Please see the changes under the changelog file.
Screenshot 2020-09-01 at 10 31 00

@huri000 huri000 closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexcurylo @huri000