Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

is it possible to set accessibilityViewIsModal true #294

Closed
AmirCa84 opened this issue Jul 18, 2020 · 3 comments
Closed

is it possible to set accessibilityViewIsModal true #294

AmirCa84 opened this issue Jul 18, 2020 · 3 comments
Labels
enhancement New feature or request idea Any idea that may be good for the future

Comments

@AmirCa84
Copy link

is it possible to set accessibilityViewIsModal to true on EKWindow? All windows are siblings so this will ignore others window for accessibility purposes.
@huri000
Copy link
Owner

huri000 commented Aug 31, 2020

You are welcome to fork and open a pull request. Unfortunately, I don't have time to experiment with solutions to this ATM, but if you are able to, please feel free to PR for my review.

@huri000 huri000 closed this as completed Aug 31, 2020
@huri000 huri000 reopened this Aug 31, 2020
@huri000 huri000 added enhancement New feature or request idea Any idea that may be good for the future labels Aug 31, 2020
huri000 added a commit that referenced this issue Sep 1, 2020
@huri000
#222 fix accessibility for buttons. #294 set accessibilityViewIsModal…
ed78457 
… for EKWindow instance
@huri000 huri000 mentioned this issue Sep 1, 2020
Merged
huri000 added a commit that referenced this issue Sep 1, 2020
@huri000
feature(Accessibility): add accessibility capabilities to button. mak…
76fd46c 
…e every `EKWindow` instance a modal for accessibility (#304)

* update README

* update README

* update README

* #222 fix accessibility for buttons. #294 set accessibilityViewIsModal for EKWindow instance
huri000 added a commit that referenced this issue Sep 1, 2020
@huri000
release(1.2.5): additional accessibility support (#305)
ccc71fd 
* update README

* update README

* update README

* #222 fix accessibility for buttons. #294 set accessibilityViewIsModal for EKWindow instance

* bump to 1.2.5
@huri000
Copy link
Owner

huri000 commented Sep 1, 2020

@AmirCa84, It turned out I had time to do this. :-)
All EKWindow instances are marked accessibilityViewIsModal = true. That seems to work properly with all types of background interactions. Please give 1.2.5 a try.

@huri000 huri000 closed this as completed Sep 1, 2020
@AmirCa84
Copy link
Author

AmirCa84 commented Sep 1, 2020

Really appreciated it. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request idea Any idea that may be good for the future
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@huri000 @AmirCa84