Support OpenBSD #156
Merged
Support OpenBSD #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This came about as a build fix for OpenBSD's new spotifyd package: ``` error[E0433]: failed to resolve: use of undeclared crate or module `default` --> .../modcargo-crates/keyring-2.0.1/src/lib.rs:176:54 ``` Local spotifyd patches to enable its keyring feature practically differ only in README.md and Cargo.toml churn; this makes keyring-rs build fine by adapting existing FreeBSD bits.
|
Sure, why not. I'll review this for formatting and then release it. Can you please open an issue requesting OpenBSD support? (I prefer to have all PRs tied to an issue.) |
brotskydotcom
approved these changes
Dec 28, 2023
Closed
Current patches for reference: |
brotskydotcom
added a commit
to brotskydotcom/keyring-rs
that referenced
this pull request
Dec 31, 2023
Also update dependencies. Thanks to @klemensn's hwchen#156 this release should fix hwchen#157.
brotskydotcom
added a commit
to brotskydotcom/keyring-rs
that referenced
this pull request
Dec 31, 2023
Also update dependencies. Thanks to @klemensn's hwchen#156 this release should fix hwchen#157.
klemensn
added a commit
to klemensn/spotifyd
that referenced
this pull request
Dec 31, 2023
After 2.2.0 I submitted hwchen/keyring-rs#156 which turned into 2.3.0 today. OpenBSD's port currently needs patches, see PR for details. I have only tested spotifyd's 0.3.5 release with this keyring bumped 2.3.0 instead of patching 2.0.5 and it works. Done with `cargo update keyring`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came about as a build fix for OpenBSD's new spotifyd package:
Local spotifyd patches to enable its keyring feature practically differ only in README.md and Cargo.toml churn; this makes keyring-rs build fine by adapting existing FreeBSD bits.