fix(transport): reconnect lazy connections after first failure #458
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Channels created with lazy connections never try to reconnect if the first connection attempt fails. This is because `Reconnect` returns `Poll::Ready(Err)` on poll_ready and the service is considered dead. This change passes a flag to Reconnect to signal if the connection is intended to be lazy, in which case reconnect returns the error on the next call. fixes hyperium#452
LucioFranco
reviewed
Sep 22, 2020
LucioFranco
approved these changes
Sep 23, 2020
|
It looks like this change, in combination with #392 leaves the |
This was referenced Mar 18, 2021
Closed
|
@dfreese yeah, I think we need to revisit some of the APIs but likely won't change anytime soon since its a breaking change and I would like to limit that until we have a proper design for larger changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Channels created with lazy connections never try to reconnect if the first connection attempt fails. This is because
ReconnectreturnsPoll::Ready(Err)onpoll_readyand the service is considered dead.This change passes a flag to Reconnect to signal if the connection is intended to be lazy, in which case reconnect returns the error on the next call. A new
Connection::lazyconstructor is provided to avoid threading booleans around.fixes #452