Endpoint::lazy_connect always tries to reconnect #460
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a connection could not be established on first connection
attempt, an error was reported and the connection never tried to reconnect.
This behaviour is kept for
Endpoint::connect
and changed forEndpoint::lazy_connect
.Motivation
The behaviour to fail on the first attempt was introduced in #413.
This makes tonic clients behave two-fold:
and it will never try to reconnect.
breaks, the client will resiliently try to reconnect.
As explained in #413 and #403, the behaviour in 1 is sometimes needed, however
there is another use case where the server we are connecting to is not yet up.
When connecting lazily, we expect the connection to
be always resilient, since we move the actual connection attempt to a later
point in time.
Solution
Endpoint::connect
.Endpoint::connect_lazy
.Note
I would appreciate a proposal if there is a better way to achieve resilient initial reconnect. Also, I am not very happy to propagate the
always_reconnect
flag through several layers, but do not see a better way to do it.