Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support msg.value in native hooks #2410

Closed
aroralanuk opened this issue Jun 20, 2023 · 1 comment
Closed

Support msg.value in native hooks #2410

aroralanuk opened this issue Jun 20, 2023 · 1 comment

Comments

@aroralanuk
Copy link
Contributor

@yorhodes yorhodes moved this to On-Deck in Hyperlane Tasks Jul 6, 2023
@nambrot nambrot moved this from On-Deck to Below Deck in Hyperlane Tasks Jul 10, 2023
This was referenced Aug 7, 2023
Closed
Merged
aroralanuk added a commit that referenced this issue Aug 15, 2023
@aroralanuk @yorhodes
Converting the OP stack hooks to transient storage version (#2632)
816cc40 
### Description

- Updated the OP Stack tests for the Mailbox V3 transient storage
version
- Allowing OPStackHook to send msg.value at the time of message delivery
(uses bit masking)
- Added LibBit library, will be useful for all the auth hooks which can
send `msg.value`

### Drive-by changes

- None

### Related issues

- Fixes breaking OP Stack tests for
hyperlane-xyz/issues#513
- Also fixes
#2410

### Backward compatibility

No

### Testing

Unit tests

---------

Co-authored-by: Yorke Rhodes <[email protected]>
yorhodes added a commit that referenced this issue Aug 18, 2023
@aroralanuk @yorhodes
Converting the OP stack hooks to transient storage version (#2632)
9d75396 
### Description

- Updated the OP Stack tests for the Mailbox V3 transient storage
version
- Allowing OPStackHook to send msg.value at the time of message delivery
(uses bit masking)
- Added LibBit library, will be useful for all the auth hooks which can
send `msg.value`

### Drive-by changes

- None

### Related issues

- Fixes breaking OP Stack tests for
hyperlane-xyz/issues#513
- Also fixes
#2410

### Backward compatibility

No

### Testing

Unit tests

---------

Co-authored-by: Yorke Rhodes <[email protected]>
yorhodes added a commit that referenced this issue Sep 13, 2023
@aroralanuk @yorhodes
Converting the OP stack hooks to transient storage version (#2632)
760dce6 
- Updated the OP Stack tests for the Mailbox V3 transient storage
version
- Allowing OPStackHook to send msg.value at the time of message delivery
(uses bit masking)
- Added LibBit library, will be useful for all the auth hooks which can
send `msg.value`

- None

- Fixes breaking OP Stack tests for
hyperlane-xyz/issues#513
- Also fixes
#2410

No

Unit tests

---------

Co-authored-by: Yorke Rhodes <[email protected]>

Remove e2e and add yarn build to CI

Adding protocol fees (#2640)

- Adding protocol fee as a hook

- None

V3

Yes

Fuzz tests

---------

Co-authored-by: Yorke Rhodes <[email protected]>
@aroralanuk
Copy link
Contributor Author

OPStack supports msg.value now

@github-project-automation github-project-automation bot moved this from Backlog to Done in Hyperlane Tasks Oct 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Archived in project
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aroralanuk