Adding protocol fees #2640
Merged
Adding protocol fees #2640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
### Description - Adding default hook using custom config ### Drive-by changes - `postDispatch` is now public ### Related issues - v3 ### Backward compatibility Yes ### Testing None
yorhodes
reviewed
Aug 11, 2023
yorhodes
reviewed
Aug 14, 2023
yorhodes
approved these changes
Aug 15, 2023
yorhodes
added a commit
that referenced
this pull request
Aug 18, 2023
### Description - Adding protocol fee as a hook ### Drive-by changes - None ### Related issues V3 ### Backward compatibility Yes ### Testing Fuzz tests --------- Co-authored-by: Yorke Rhodes <[email protected]>
Closed
yorhodes
added a commit
that referenced
this pull request
Sep 13, 2023
- Updated the OP Stack tests for the Mailbox V3 transient storage version - Allowing OPStackHook to send msg.value at the time of message delivery (uses bit masking) - Added LibBit library, will be useful for all the auth hooks which can send `msg.value` - None - Fixes breaking OP Stack tests for hyperlane-xyz/issues#513 - Also fixes #2410 No Unit tests --------- Co-authored-by: Yorke Rhodes <[email protected]> Remove e2e and add yarn build to CI Adding protocol fees (#2640) - Adding protocol fee as a hook - None V3 Yes Fuzz tests --------- Co-authored-by: Yorke Rhodes <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Drive-by changes
Related issues
V3
Backward compatibility
Yes
Testing
Fuzz tests