Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix core fork tests #2014

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Fix core fork tests #2014

merged 4 commits into from
Mar 24, 2023

Conversation

yorhodes
Copy link
Member

Changed in #1907

Testing

Fork tests

@yorhodes
Update fork.sh
2c16e97 
Changed in #1907
@yorhodes yorhodes marked this pull request as ready for review March 24, 2023 15:05
asaj
asaj suggested changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@asaj asaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not merge until failures cause CI to fail

typescript/infra/fork.sh Show resolved Hide resolved
@yorhodes yorhodes requested a review from asaj March 24, 2023 15:12
@yorhodes yorhodes enabled auto-merge (squash) March 24, 2023 15:19
@yorhodes yorhodes changed the title Update fork.sh Fix core fork tests Mar 24, 2023
@yorhodes yorhodes merged commit 33693a1 into main Mar 24, 2023
@yorhodes yorhodes deleted the yorhodes-patch-2 branch March 24, 2023 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asaj asaj asaj approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@nambrot nambrot Awaiting requested review from nambrot

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yorhodes @asaj