Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: zksync support for core solidity package #5205

Merged
merged 253 commits into from
Jan 22, 2025
Merged

feat: zksync support for core solidity package #5205

merged 253 commits into from
Jan 22, 2025

Conversation

ljankovic-txfusion
Copy link
Collaborator

@ljankovic-txfusion ljankovic-txfusion commented Jan 20, 2025 •
edited by paulbalaji
Loading

Description

ZKSync PR 1

This PR introduces ZKSync support for Solidity contracts and restructures build files directory structure.

Drive-by changes

  • Added ZKSync compilation support using zksolc via @matterlabs/hardhat-zksync-solc
  • Restructured typechain directory location to core-utils/typechain
  • Decoupled Hardhat configuration for ZKSync from EVM.
  • Updated build process to handle both standard and ZKSync contract artifacts

Related issues

None

Backward compatibility

Yes

Testing

Testing was previously in feat: zksync support PR

ljankovic-txfusion and others added 30 commits September 16, 2024 15:11
@ljankovic-txfusion
chore: remove non-compatible zksync code from SDK
0a692b3
@ljankovic-txfusion
feature: exporting zksync contract artifacts from core
de77dba
@ljankovic-txfusion
feat: zksync deployer
1e1d748
@ljankovic-txfusion
fix: artifacts compilation; add:typechain-types to .gitignore
2848efe
@ljankovic-txfusion
update: wip deploying contracts via cli
79ceac4
@ljankovic-txfusion
update: load artifacts from factory
04f390c
@ljankovic-txfusion
feat: cli bash script for automating core deployment
e76bbf2
@ljankovic-txfusion
update: wip sdk hardhat test on zksync
e1929f8
@ljankovic-txfusion
update: wip making sdk tests compatible with zksync
8b2596a
@ljankovic-txfusion
cleanup: minor test changes
e10d557
@ljankovic-txfusion
cleanup: minor changes
e4cef73
@ljankovic-txfusion
fix: should derive a token type from contract
2d2fb15
@ljankovic-txfusion
chore: refactoring multi provider
a29df94
@ljankovic-txfusion
feat: ProviderTypes for zksync
49c3812
@ljankovic-txfusion
refactor: deployment gasLimit for in memory node
82e0938
@ljankovic-txfusion
feat: relaying messages locally
53f8e61
@ljankovic-txfusion
chore: remove gasLimit overrides for zksync
3022cd0
@ljankovic-txfusion
refactor: MultiProvider added defaultZKProviderBuilder in tryGetProvider
3e3637a
@ljankovic-txfusion
feat: singe cli/sdk to deploy to both evm and zkevm chains
23f6e94
@mortezashojaei
feat: mutable storage multisig ISM
733572a
@mortezashojaei
fix: add missing addBufferToGasLimit function on utils
629a4c8
@ljankovic-txfusion
feat: compile contracts with solc & zksolc using single command
2c0cb55
@mortezashojaei
minor: cleanup
dcaecea
@mortezashojaei
feature: support zksync protocol in addresses utils
36244c9
@mortezashojaei
minor: cleanup
ecb3c49
@mortezashojaei
minot: revert back estimate handle in HyperlaneRelayer
2b76f59
@ljankovic-txfusion
feat: zksync support for TypedTransaction
0ea4e51
@ljankovic-txfusion
Merge branch 'txfusion/sending-messages' of github.com:hyperlane-xyz/…
74c3a67 
…hyperlane-monorepo-zksync into txfusion/sending-messages
@mortezashojaei
fix: prevent handle estimation on zksync protocol
15de0ad
@ljankovic-txfusion
feat: deploying StorageMerkleRootMultisigIsm
50903a6
@codecov Codecov
Copy link

codecov bot commented Jan 21, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (6c631d8) to head (3adda1d).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #5205   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

yorhodes
yorhodes approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@yorhodes yorhodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

.changeset/chatty-starfishes-double.md Outdated Show resolved Hide resolved
solidity/package.json Outdated Show resolved Hide resolved
@yorhodes yorhodes assigned yorhodes and unassigned yorhodes Jan 21, 2025
nambrot
nambrot approved these changes Jan 21, 2025
View reviewed changes
solidity/generate-artifact-exports.mjs Show resolved Hide resolved
solidity/package.json Outdated Show resolved Hide resolved
@paulbalaji paulbalaji enabled auto-merge January 22, 2025 18:06
@paulbalaji paulbalaji disabled auto-merge January 22, 2025 18:20
@paulbalaji paulbalaji added this pull request to the merge queue Jan 22, 2025
Merged via the queue into hyperlane-xyz:main with commit db8c090 Jan 22, 2025
39 of 45 checks passed
@paulbalaji paulbalaji mentioned this pull request Jan 23, 2025
Merged
paulbalaji added a commit that referenced this pull request Jan 23, 2025
@paulbalaji
Revert "feat: zksync support for core solidity package (#5205)"
8d3b9d6 
This reverts commit db8c090.
github-merge-queue bot pushed a commit that referenced this pull request Jan 23, 2025
@paulbalaji
revert: "feat: zksync support for core solidity package" (#5275)
4176df1 
Reverts #5205
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nambrot nambrot nambrot approved these changes

@paulbalaji paulbalaji paulbalaji left review comments

@yorhodes yorhodes yorhodes approved these changes

@tkporter tkporter Awaiting requested review from tkporter tkporter is a code owner

@aroralanuk aroralanuk Awaiting requested review from aroralanuk aroralanuk is a code owner

@ltyu ltyu Awaiting requested review from ltyu ltyu is a code owner

Assignees
No one assigned
Labels
None yet
Projects
Hyperlane Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@ljankovic-txfusion @nambrot @yorhodes @paulbalaji @mortezashojaei @mshojaei-txfusion @ltyu