Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

revert: "feat: zksync support for core solidity package" #5275

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

paulbalaji
Copy link
Contributor

Reverts #5205

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 4f153b5f3d272d57782d1b85274bd6a9ff51cda1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@paulbalaji
Copy link
Contributor Author

will have to pull main after #5274 is merged i think

@paulbalaji paulbalaji changed the title Revert "feat: zksync support for core solidity package" revert: "feat: zksync support for core solidity package" Jan 23, 2025
@paulbalaji paulbalaji force-pushed the revert-5205-feat/core-zksync branch from 4f153b5 to 8d3b9d6 Compare January 23, 2025 19:42
Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.53%. Comparing base (6b58f2f) to head (8d3b9d6).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5275   +/-   ##
=======================================
  Coverage   77.53%   77.53%           
=======================================
  Files         103      103           
  Lines        2110     2110           
  Branches      190      190           
=======================================
  Hits         1636     1636           
  Misses        453      453           
  Partials       21       21           
Components Coverage Δ
core 87.80% <ø> (ø)
hooks 79.39% <ø> (ø)
isms 83.68% <ø> (ø)
token 91.27% <ø> (ø)
middlewares 79.80% <ø> (ø)

@paulbalaji paulbalaji enabled auto-merge January 23, 2025 20:20
@paulbalaji paulbalaji added this pull request to the merge queue Jan 23, 2025
Merged via the queue into main with commit 4176df1 Jan 23, 2025
46 checks passed
@paulbalaji paulbalaji deleted the revert-5205-feat/core-zksync branch January 23, 2025 20:45
github-merge-queue bot pushed a commit that referenced this pull request Jan 24, 2025
### Description

changeset for zksync revert

#5274
#5275

### Drive-by changes

<!--
Are there any minor or drive-by changes also included?
-->

### Related issues

<!--
- Fixes #[issue number here]
-->

### Backward compatibility

<!--
Are these changes backward compatible? Are there any infrastructure
implications, e.g. changes that would prohibit deploying older commits
using this infra tooling?

Yes/No
-->

### Testing

<!--
What kind of testing have these changes undergone?

None/Manual/Unit Tests
-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants