Skip to content
This repository has been archived by the owner on Mar 27, 2024. It is now read-only.

fix Ed25519 KID value #2530

Closed
baha-ai opened this issue Feb 10, 2021 · 0 comments · Fixed by #2533
Closed

fix Ed25519 KID value #2530

baha-ai opened this issue Feb 10, 2021 · 0 comments · Fixed by #2533
Assignees
@baha-ai
Labels
bug Something isn't working
Milestone
v0.1.6

Comments

@baha-ai
Copy link
Contributor

baha-ai commented Feb 10, 2021

Currently KIDs are based on the public key's JWK thumbprint.

There's a bug for Ed25519 JWK thumbprints in go-jose.

Fix this manually in the framework as the go-jose fix might take a while to be merged in their Github repo.
@baha-ai baha-ai self-assigned this Feb 10, 2021
@baha-ai baha-ai added the bug Something isn't working label Feb 10, 2021
@baha-ai baha-ai added this to the v0.1.6 milestone Feb 10, 2021
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue Feb 11, 2021
fix: wrong Ed25519 KID value
daaa01b 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
@baha-ai baha-ai mentioned this issue Feb 11, 2021
Merged
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue Feb 11, 2021
fix: wrong Ed25519 KID value
dd18d92 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future change when the server image tag
is updated.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue Feb 11, 2021
fix: wrong Ed25519 KID value
9622de8 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future change when the server image tag
is updated.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue Feb 11, 2021
fix: wrong Ed25519 KID value
dbbc7cb 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future change when the server image tag
is updated.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue Feb 11, 2021
fix: wrong Ed25519 KID value
7e74a86 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future revision when the server image tag
is updated with a revision of aries-framework-go that contains this change.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue Feb 11, 2021
fix: wrong Ed25519 KID value
694f929 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future revision when the server image tag
is updated with a revision of aries-framework-go that contains this change.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
baha-ai pushed a commit to baha-ai/aries-framework-go that referenced this issue Feb 12, 2021
fix: wrong Ed25519 KID value
2b30422 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future revision when the server image tag
is updated with a revision of aries-framework-go that contains this change.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
troyronda pushed a commit that referenced this issue Feb 12, 2021
@baha-ai
fix: wrong Ed25519 KID value (#2533)
b94cce1 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future revision when the server image tag
is updated with a revision of aries-framework-go that contains this change.

closes #2530

Signed-off-by: Baha Shaaban <[email protected]>
@baha-ai baha-ai mentioned this issue Mar 5, 2021
Open
sudeshrshetty pushed a commit to sudeshrshetty/aries-framework-go that referenced this issue Oct 18, 2021
@baha-ai @sudeshrshetty
fix: wrong Ed25519 KID value (hyperledger-archives#2533)
74c6cd9 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future revision when the server image tag
is updated with a revision of aries-framework-go that contains this change.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
sudeshrshetty pushed a commit to sudeshrshetty/aries-framework-go that referenced this issue Jan 22, 2022
@baha-ai @sudeshrshetty
fix: wrong Ed25519 KID value (hyperledger-archives#2533)
55511cc 
This change fixes go-jose's Ed25519 JWK Thumbprint value used in the KMS KID creation.

It also includes a check for emptiness of the key bytes with calling CreateKID() and
fixed related unit tests in the framework.

Finally the webkms bdd tests are commented out since the remote kms server requires
an udpate. They will be uncommented in a future revision when the server image tag
is updated with a revision of aries-framework-go that contains this change.

closes hyperledger-archives#2530

Signed-off-by: Baha Shaaban <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@baha-ai baha-ai

Labels
bug Something isn't working
Milestone
v0.1.6
Development

Successfully merging a pull request may close this issue.

fix: wrong Ed25519 KID value baha-ai/aries-framework-go
1 participant
@baha-ai