-
Notifications
You must be signed in to change notification settings - Fork 275
Fix JWK Thumbprint/kid for Ed25519 keys #324
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution!
Hi @csstaub , is there any plan for merge? |
Looks like I don't have permissions to merge on master anymore. Hi @mcpherrinm and @mbyczkowski 👋, can I get your help merging this or can you add me back to the master branch on the repo? Thank you. |
We need this fix as well. @szkiba it looks like there's a branch conflict, is this true? if yes, can you rebase / fix the merge conflict? |
@csstaub master code has been removed, I believe this PR should be merged into v2 branch instead. |
@Baha-sk as I see the situation is not clean :) I opened this PR half year ago, and there was no conflict. As I understand from your message, there is an upcoming major release on different branch. It is just an 1 letter change, so it would be much simpler, if someone put this one missing double quote :) |
@szkiba It seems the project was forked by the authors into: https://github.com/go-jose/go-jose I guess the authors can add a manual commit with the tiny fix in the right branch, or shall we submit a pr to github.com/go-jose/go-jose ? @csstaub, @mcpherrinm , @mbyczkowski, how/where is go-jose maintained exactly? Please advise. |
I merged this as a fix in the v3 branch in github.com/go-jose/go-jose |
The format string edThumbprintTemplate was broken, missing opening " before x property name. It cause interoperability issues with other JOSE implementations.