Skip to content
This repository has been archived by the owner on Feb 27, 2023. It is now read-only.

Fix JWK Thumbprint/kid for Ed25519 keys #324

Closed
wants to merge 1 commit into from
Closed

Conversation

szkiba
Copy link

@szkiba szkiba commented Jul 19, 2020

The format string edThumbprintTemplate was broken, missing opening " before x property name. It cause interoperability issues with other JOSE implementations.

@CLAassistant
Copy link

CLAassistant commented Jul 19, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@csstaub csstaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@szkiba
Copy link
Author

szkiba commented Jul 23, 2020

Hi @csstaub , is there any plan for merge?

@csstaub
Copy link
Collaborator

csstaub commented Jul 23, 2020

Looks like I don't have permissions to merge on master anymore. Hi @mcpherrinm and @mbyczkowski 👋, can I get your help merging this or can you add me back to the master branch on the repo? Thank you.

@baha-ai
Copy link

baha-ai commented Feb 3, 2021

We need this fix as well.

@szkiba it looks like there's a branch conflict, is this true? if yes, can you rebase / fix the merge conflict?

@baha-ai
Copy link

baha-ai commented Feb 3, 2021

Looks like I don't have permissions to merge on master anymore. Hi @mcpherrinm and @mbyczkowski 👋, can I get your help merging this or can you add me back to the master branch on the repo? Thank you.

@csstaub master code has been removed, I believe this PR should be merged into v2 branch instead.

@szkiba
Copy link
Author

szkiba commented Feb 3, 2021

Looks like I don't have permissions to merge on master anymore. Hi @mcpherrinm and @mbyczkowski wave, can I get your help merging this or can you add me back to the master branch on the repo? Thank you.

@csstaub master code has been removed, I believe this PR should be merged into v2 branch instead.

@Baha-sk as I see the situation is not clean :) I opened this PR half year ago, and there was no conflict. As I understand from your message, there is an upcoming major release on different branch.

It is just an 1 letter change, so it would be much simpler, if someone put this one missing double quote :)

@baha-ai
Copy link

baha-ai commented Feb 3, 2021

@Baha-sk as I see the situation is not clean :) I opened this PR half year ago, and there was no conflict. As I understand from your message, there is an upcoming major release on different branch.

It is just an 1 letter change, so it would be much simpler, if someone put this one missing double quote :)

@szkiba It seems the project was forked by the authors into: https://github.com/go-jose/go-jose
you can probably push a PR there instead since I believe the fork is under active development.

I guess the authors can add a manual commit with the tiny fix in the right branch, or shall we submit a pr to github.com/go-jose/go-jose ? @csstaub, @mcpherrinm , @mbyczkowski, how/where is go-jose maintained exactly? Please advise.

@csstaub
Copy link
Collaborator

csstaub commented Jun 5, 2021

I merged this as a fix in the v3 branch in github.com/go-jose/go-jose

@csstaub csstaub closed this Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants