feat(cactus-plugin-ledger-connector-ethereum): refactor connector API

- Refactor to single `invokeContract` endpoint that can accept multiple methods of
    supplying contract definition (directly, from keychain, etc..).
- Same for `deployContract` method.
- Update cactus-common `safeStringifyException` function to better handle axios errors
    (and other custom exceptions that support `toJSON()` method.).
- Use common error handling in all connector endpoints (except prometheus).
- Fix the tests.
- Switch to `Cacti` work in entire connector (except for package name)

Depends on: #2630

Signed-off-by: Michal Bajer <[email protected]>

.github/workflows/ci.yaml

@@ -1593,13 +1593,13 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-yarn-${{ hashFiles('./yarn.lock') }}
       - run: ./tools/ci.sh
-      
+
       - name: Install Foundry
         uses: foundry-rs/foundry-toolchain@v1
 
       - name: Run solidity tests
         run: cd packages/cactus-plugin-htlc-eth-besu && forge test -vvvvv
-              
+
   cactus-test-plugin-htlc-eth-besu-erc20:
     continue-on-error: false
     env:

packages/cactus-common/src/main/typescript/error-utils.ts

@@ -28,5 +28,16 @@ export function safeStringifyException(error: unknown): string {
     return sanitizeHtml(error.stack || error.message);
   }
 
+  // Axios and possibly other lib errors produce nicer output with toJSON() method.
+  // Use it if available
+  if (
+    error &&
+    typeof error === "object" &&
+    "toJSON" in error &&
+    typeof error.toJSON === "function"
+  ) {
+    return sanitizeHtml(error.toJSON());
+  }
+
   return sanitizeHtml(safeStringify(error));
 }

packages/cactus-plugin-ledger-connector-ethereum/README.md

@@ -51,7 +51,7 @@ async transact(req: RunTransactionRequest): Promise<RunTransactionResponse>;
 async transactSigned(rawTransaction: string): Promise<RunTransactionResponse>;
 async transactGethKeychain(txIn: RunTransactionRequest): Promise<RunTransactionResponse>;
 async transactPrivateKey(req: RunTransactionRequest): Promise<RunTransactionResponse>;
-async transactCactusKeychainRef(req: RunTransactionRequest):Promise<RunTransactionResponse>;
+async transactCactiKeychainRef(req: RunTransactionRequest):Promise<RunTransactionResponse>;
 async deployContract(req: DeployContractSolidityBytecodeV1Request :Promise<DeployContractSolidityBytecodeV1Response>;
 async deployContractJsonObject(req: DeployContractSolidityBytecodeJsonObjectV1Request): Promise<DeployContractSolidityBytecodeV1Response>
 async invokeRawWeb3EthMethod(req: InvokeRawWeb3EthMethodV1Request): Promise<any>;
@@ -76,7 +76,7 @@ The field "type" can have the following values:
 
 ```typescript
 enum Web3SigningCredentialType {
-  CACTUSKEYCHAINREF = "CACTUS_KEYCHAIN_REF",
+  CACTUSKEYCHAINREF = "CACTI_KEYCHAIN_REF",
   GETHKEYCHAINPASSWORD = "GETH_KEYCHAIN_PASSWORD",
   PRIVATEKEYHEX = "PRIVATE_KEY_HEX",
   NONE = "NONE",

packages/cactus-plugin-ledger-connector-ethereum/package.json

@@ -1,9 +1,10 @@
 {
   "name": "@hyperledger/cactus-plugin-ledger-connector-ethereum",
   "version": "2.0.0-alpha.1",
-  "description": "Allows Cactus nodes to connect to a Ethereum ledger.",
+  "description": "Allows Cacti nodes to connect to a Ethereum ledger.",
   "keywords": [
     "Hyperledger",
+    "Cacti",
     "Cactus",
     "Integration",
     "Blockchain",
@@ -19,9 +20,9 @@
   },
   "license": "Apache-2.0",
   "author": {
-    "name": "Hyperledger Cactus Contributors",
-    "email": "cactus@lists.hyperledger.org",
-    "url": "https://www.hyperledger.org/use/cactus"
+    "name": "Hyperledger Cacti Contributors",
+    "email": "cacti@lists.hyperledger.org",
+    "url": "https://www.hyperledger.org/use/cacti"
   },
   "contributors": [
     {