Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cmd-socketio-server): Enable tsconfig strict flag and fix all the warnings #1671

Closed
6 tasks done
outSH opened this issue Dec 21, 2021 · 2 comments
Closed
6 tasks done

fix(cmd-socketio-server): Enable tsconfig strict flag and fix all the warnings #1671

outSH opened this issue Dec 21, 2021 · 2 comments
Labels
bug Something isn't working

Comments

@outSH
Copy link
Contributor

outSH commented Dec 21, 2021 •
edited
Loading

Depends on #1647

Some projects has temporarily disabled strict flag in their tsconfig. We must enable it and fix all the warnings that appears.

Affected projects:

  • ./packages/cactus-cmd-socketio-server
  • ./packages/cactus-plugin-ledger-connector-fabric-socketio
  • ./packages/cactus-plugin-ledger-connector-go-ethereum-socketio
  • ./packages/cactus-plugin-ledger-connector-sawtooth-socketio
  • ./examples/cactus-example-electricity-trade
  • ./examples/cactus-example-discounted-asset-trade
@outSH outSH added the bug Something isn't working label Dec 21, 2021
@outSH outSH mentioned this issue Dec 21, 2021
Merged
@outSH outSH mentioned this issue Feb 18, 2022
Merged
outSH added a commit to outSH/cactus that referenced this issue Apr 15, 2022
@outSH
refactor(connector-fabric-socketio): fix strict flag warnings
17641c1 
cactus-plugin-ledger-connector-fabric-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH mentioned this issue Apr 15, 2022
Merged
petermetz pushed a commit to outSH/cactus that referenced this issue Apr 26, 2022
@outSH @petermetz
refactor(connector-fabric-socketio): fix strict flag warnings
a79e8de 
cactus-plugin-ledger-connector-fabric-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit that referenced this issue Apr 26, 2022
@outSH @petermetz
refactor(connector-fabric-socketio): fix strict flag warnings
232e5c1 
cactus-plugin-ledger-connector-fabric-socketio will compile with global strict flag.

Related issue: #1671

Signed-off-by: Michal Bajer <[email protected]>
micoferdinand98 pushed a commit to micoferdinand98/cactus that referenced this issue May 5, 2022
@outSH @micoferdinand98
refactor(connector-fabric-socketio): fix strict flag warnings
9028524 
cactus-plugin-ledger-connector-fabric-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
@github-actions
Copy link

This PR/issue depends on:

zondervancalvez pushed a commit to zondervancalvez/cactus that referenced this issue May 18, 2022
@outSH @zondervancalvez
refactor(connector-fabric-socketio): fix strict flag warnings
6911325 
cactus-plugin-ledger-connector-fabric-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this issue May 27, 2022
@outSH
refactor(connector-go-ethereum-socketio): fix strict flag warnings
08119f3 
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this issue May 31, 2022
@outSH
refactor(connector-go-ethereum-socketio): fix strict flag warnings
eb31f12 
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH mentioned this issue May 31, 2022
Merged
outSH added a commit to outSH/cactus that referenced this issue Jun 29, 2022
@outSH
refactor(connector-go-ethereum-socketio): fix strict flag warnings
87fef17 
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this issue Jul 1, 2022
@outSH
refactor(connector-sawtooth-socketio): fix strict flag warnings
3cbf137 
cactus-plugin-ledger-connector-sawtooth-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
@outSH outSH mentioned this issue Jul 1, 2022
Merged
outSH added a commit to outSH/cactus that referenced this issue Jul 1, 2022
@outSH
refactor(connector-sawtooth-socketio): fix strict flag warnings
3da744a 
cactus-plugin-ledger-connector-sawtooth-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this issue Jul 12, 2022
@outSH
refactor(connector-go-ethereum-socketio): fix strict flag warnings
490ebf9 
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit to outSH/cactus that referenced this issue Jul 13, 2022
@outSH @petermetz
refactor(connector-go-ethereum-socketio): fix strict flag warnings
8e2d8db 
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
outSH added a commit to outSH/cactus that referenced this issue Jul 14, 2022
@outSH
refactor(connector-go-ethereum-socketio): fix strict flag warnings
c25e70f 
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit to outSH/cactus that referenced this issue Jul 14, 2022
@outSH @petermetz
refactor(connector-go-ethereum-socketio): fix strict flag warnings
7e3ee0d 
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
takeutak pushed a commit that referenced this issue Jul 15, 2022
@outSH @takeutak
refactor(connector-go-ethereum-socketio): fix strict flag warnings
599205a 
cactus-plugin-ledger-connector-go-ethereum-socketio will compile with global strict flag.

Related issue: #1671

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit to outSH/cactus that referenced this issue Jul 20, 2022
@outSH @petermetz
refactor(connector-sawtooth-socketio): fix strict flag warnings
e256027 
cactus-plugin-ledger-connector-sawtooth-socketio will compile with global strict flag.

Related issue: hyperledger-cacti#1671

Signed-off-by: Michal Bajer <[email protected]>
petermetz pushed a commit that referenced this issue Jul 20, 2022
@outSH @petermetz
refactor(connector-sawtooth-socketio): fix strict flag warnings
5ad0f84 
cactus-plugin-ledger-connector-sawtooth-socketio will compile with global strict flag.

Related issue: #1671

Signed-off-by: Michal Bajer <[email protected]>
This was referenced Aug 12, 2022
Closed
Closed
@outSH
Copy link
Contributor Author

outSH commented Nov 2, 2022

All packages are fixed now

@outSH outSH closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@outSH