refactor(connector-fabric-socketio): fix strict flag warnings #1975
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Apr 15, 2022
Added functional jest test fabric-socketio-connector.test that can be run during CI process. It checks evaluate/sending transactions and monitoring for new events. Connector had to be refactored to be testable, tests also discovered some bugs that had to be fixed in order to pass. SocketIOApiClient refactors: - Added option for supplying validatorKeyValue instead of validatorKeyPath. - JWT validation function works with key value now (instead of reading the key). - Validator can now return messages that are not encrypted (it throwed error previously). - Adjusted unit tests. connector-fabric-socketio refactors: - Connector can be run both as a standalone app and loaded as a module (www.js file). Caller can use exported startFabricSocketIOConnector function to run the connector. Configuration must be supplied in file or in env variable like it's done in functional test. - All cryptographic data (keys, certificates, etc…) can now be supplied as a value (previously it supported only path to a file). - sendSignedTransaction can now be called synchronously (it had wrong response format before). - Fixed a bug introduced during my last changes in this component, which caused fabric-client session to be disconnected but still reused by follow-up requests. I didn't know that gateway disconnects client it operates on. - Increased JWT expiration to 15 minutes to prevent constant JWT expiration error (I'm pretty sure 15 minutes is still secure period). - Minor improvements (logging, formatting, etc…) fabric-test-ledger-v1 changes: - Added adminCredentials to have programatic access to admin credentials on currently used ledger (unlikely, but can change in the future). Depends on: hyperledger-cacti#1975 Closes: hyperledger-cacti#1976 Signed-off-by: Michal Bajer <[email protected]>
|
@petermetz @izuru0 Please review |
outSH
added a commit
to outSH/cactus
that referenced
this pull request
Apr 19, 2022
Added functional jest test fabric-socketio-connector.test that can be run during CI process. It checks evaluate/sending transactions and monitoring for new events. Connector had to be refactored to be testable, tests also discovered some bugs that had to be fixed in order to pass. SocketIOApiClient refactors: - Added option for supplying validatorKeyValue instead of validatorKeyPath. - JWT validation function works with key value now (instead of reading the key). - Validator can now return messages that are not encrypted (it throwed error previously). - Adjusted unit tests. connector-fabric-socketio refactors: - Connector can be run both as a standalone app and loaded as a module (www.js file). Caller can use exported startFabricSocketIOConnector function to run the connector. Configuration must be supplied in file or in env variable like it's done in functional test. - All cryptographic data (keys, certificates, etc…) can now be supplied as a value (previously it supported only path to a file). - sendSignedTransaction can now be called synchronously (it had wrong response format before). - Fixed a bug introduced during my last changes in this component, which caused fabric-client session to be disconnected but still reused by follow-up requests. I didn't know that gateway disconnects client it operates on. - Increased JWT expiration to 15 minutes to prevent constant JWT expiration error (I'm pretty sure 15 minutes is still secure period). - Minor improvements (logging, formatting, etc…) fabric-test-ledger-v1 changes: - Added adminCredentials to have programatic access to admin credentials on currently used ledger (unlikely, but can change in the future). Depends on: hyperledger-cacti#1975 Closes: hyperledger-cacti#1976 Signed-off-by: Michal Bajer <[email protected]>
cactus-plugin-ledger-connector-fabric-socketio will compile with global strict flag. Related issue: hyperledger-cacti#1671 Signed-off-by: Michal Bajer <[email protected]>
petermetz
force-pushed
the
fabric_socketio_strict_warn_fix_pr
branch
from
17641c1 to
a79e8de
Compare
outSH
added a commit
to outSH/cactus
that referenced
this pull request
May 11, 2022
Added functional jest test fabric-socketio-connector.test that can be run during CI process. It checks evaluate/sending transactions and monitoring for new events. Connector had to be refactored to be testable, tests also discovered some bugs that had to be fixed in order to pass. SocketIOApiClient refactors: - Added option for supplying validatorKeyValue instead of validatorKeyPath. - JWT validation function works with key value now (instead of reading the key). - Validator can now return messages that are not encrypted (it throwed error previously). - Adjusted unit tests. connector-fabric-socketio refactors: - Connector can be run both as a standalone app and loaded as a module (www.js file). Caller can use exported startFabricSocketIOConnector function to run the connector. Configuration must be supplied in file or in env variable like it's done in functional test. - All cryptographic data (keys, certificates, etc…) can now be supplied as a value (previously it supported only path to a file). - sendSignedTransaction can now be called synchronously (it had wrong response format before). - Fixed a bug introduced during my last changes in this component, which caused fabric-client session to be disconnected but still reused by follow-up requests. I didn't know that gateway disconnects client it operates on. - Increased JWT expiration to 15 minutes to prevent constant JWT expiration error (I'm pretty sure 15 minutes is still secure period). - Minor improvements (logging, formatting, etc…) fabric-test-ledger-v1 changes: - Added adminCredentials to have programatic access to admin credentials on currently used ledger (unlikely, but can change in the future). Depends on: hyperledger-cacti#1975 Closes: hyperledger-cacti#1976 Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
May 19, 2022
Added functional jest test fabric-socketio-connector.test that can be run during CI process. It checks evaluate/sending transactions and monitoring for new events. Connector had to be refactored to be testable, tests also discovered some bugs that had to be fixed in order to pass. SocketIOApiClient refactors: - Added option for supplying validatorKeyValue instead of validatorKeyPath. - JWT validation function works with key value now (instead of reading the key). - Validator can now return messages that are not encrypted (it throwed error previously). - Adjusted unit tests. connector-fabric-socketio refactors: - Connector can be run both as a standalone app and loaded as a module (www.js file). Caller can use exported startFabricSocketIOConnector function to run the connector. Configuration must be supplied in file or in env variable like it's done in functional test. - All cryptographic data (keys, certificates, etc…) can now be supplied as a value (previously it supported only path to a file). - sendSignedTransaction can now be called synchronously (it had wrong response format before). - Fixed a bug introduced during my last changes in this component, which caused fabric-client session to be disconnected but still reused by follow-up requests. I didn't know that gateway disconnects client it operates on. - Increased JWT expiration to 15 minutes to prevent constant JWT expiration error (I'm pretty sure 15 minutes is still secure period). - Minor improvements (logging, formatting, etc…) fabric-test-ledger-v1 changes: - Added adminCredentials to have programatic access to admin credentials on currently used ledger (unlikely, but can change in the future). Depends on: hyperledger-cacti#1975 Closes: hyperledger-cacti#1976 Signed-off-by: Michal Bajer <[email protected]>
outSH
added a commit
to outSH/cactus
that referenced
this pull request
May 27, 2022
Added functional jest test fabric-socketio-connector.test that can be run during CI process. It checks evaluate/sending transactions and monitoring for new events. Connector had to be refactored to be testable, tests also discovered some bugs that had to be fixed in order to pass. SocketIOApiClient refactors: - Added option for supplying validatorKeyValue instead of validatorKeyPath. - JWT validation function works with key value now (instead of reading the key). - Validator can now return messages that are not encrypted (it throwed error previously). - Adjusted unit tests. connector-fabric-socketio refactors: - Connector can be run both as a standalone app and loaded as a module (www.js file). Caller can use exported startFabricSocketIOConnector function to run the connector. Configuration must be supplied in file or in env variable like it's done in functional test. - All cryptographic data (keys, certificates, etc…) can now be supplied as a value (previously it supported only path to a file). - sendSignedTransaction can now be called synchronously (it had wrong response format before). - Fixed a bug introduced during my last changes in this component, which caused fabric-client session to be disconnected but still reused by follow-up requests. I didn't know that gateway disconnects client it operates on. - Increased JWT expiration to 15 minutes to prevent constant JWT expiration error (I'm pretty sure 15 minutes is still secure period). - Minor improvements (logging, formatting, etc…) fabric-test-ledger-v1 changes: - Added adminCredentials to have programatic access to admin credentials on currently used ledger (unlikely, but can change in the future). Depends on: hyperledger-cacti#1975 Closes: hyperledger-cacti#1976 Signed-off-by: Michal Bajer <[email protected]>
petermetz
pushed a commit
that referenced
this pull request
May 28, 2022
Added functional jest test fabric-socketio-connector.test that can be run during CI process. It checks evaluate/sending transactions and monitoring for new events. Connector had to be refactored to be testable, tests also discovered some bugs that had to be fixed in order to pass. SocketIOApiClient refactors: - Added option for supplying validatorKeyValue instead of validatorKeyPath. - JWT validation function works with key value now (instead of reading the key). - Validator can now return messages that are not encrypted (it throwed error previously). - Adjusted unit tests. connector-fabric-socketio refactors: - Connector can be run both as a standalone app and loaded as a module (www.js file). Caller can use exported startFabricSocketIOConnector function to run the connector. Configuration must be supplied in file or in env variable like it's done in functional test. - All cryptographic data (keys, certificates, etc…) can now be supplied as a value (previously it supported only path to a file). - sendSignedTransaction can now be called synchronously (it had wrong response format before). - Fixed a bug introduced during my last changes in this component, which caused fabric-client session to be disconnected but still reused by follow-up requests. I didn't know that gateway disconnects client it operates on. - Increased JWT expiration to 15 minutes to prevent constant JWT expiration error (I'm pretty sure 15 minutes is still secure period). - Minor improvements (logging, formatting, etc…) fabric-test-ledger-v1 changes: - Added adminCredentials to have programatic access to admin credentials on currently used ledger (unlikely, but can change in the future). Depends on: #1975 Closes: #1976 Signed-off-by: Michal Bajer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cactus-plugin-ledger-connector-fabric-socketio will compile with global strict flag.
Related issue: #1671
Signed-off-by: Michal Bajer [email protected]