Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Apply fcu even on invalid payload #5961

Merged
merged 6 commits into from
Sep 28, 2023
Merged

Apply fcu even on invalid payload #5961

merged 6 commits into from
Sep 28, 2023

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Sep 28, 2023

Fixes more Hive tests when a payload that is invalid is passed along with an FCU

@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

macfarla
macfarla approved these changes Sep 28, 2023
View reviewed changes
Copy link
Contributor

@macfarla macfarla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. just spotless

@jflo jflo mentioned this pull request Sep 28, 2023
Closed
@jflo jflo force-pushed the applyFcuEvenOnInvalidPayload branch from 8dd655a to c1107e4 Compare September 28, 2023 02:34
@jflo jflo enabled auto-merge (squash) September 28, 2023 02:34
@jflo jflo merged commit ef2d418 into hyperledger:main Sep 28, 2023
@fab-10
Copy link
Contributor

fab-10 commented Sep 28, 2023

Could you add an example of the invalid payload?

jflo added a commit to jflo/besu that referenced this pull request Nov 10, 2023
@jflo
Apply fcu even on invalid payload (hyperledger#5961)
267e4d7 
* payload validation moved earlier, fcu v2 checks for cancun timestamps
* allow fcu when payload invalid
---------

Signed-off-by: Justin Florentine <[email protected]>
NickSneo pushed a commit to NickSneo/besu that referenced this pull request Nov 12, 2023
@jflo @NickSneo
Apply fcu even on invalid payload (hyperledger#5961)
a90b846 
* payload validation moved earlier, fcu v2 checks for cancun timestamps
* allow fcu when payload invalid
---------

Signed-off-by: Justin Florentine <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@macfarla macfarla macfarla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jflo @fab-10 @macfarla