Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow BLOB txs during shanghai #5963

Closed
wants to merge 2 commits into from

Conversation

jflo
Copy link
Contributor

@jflo jflo commented Sep 28, 2023

covers first block after the fork case, merge after #5961

Signed-off-by: Justin Florentine <[email protected]>
@github-actions
Copy link

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.
  • I thought about the changelog and included a changelog update if required.
  • If my PR includes database changes (e.g. KeyValueSegmentIdentifier) I have thought about compatibility and performed forwards and backwards compatibility tests

Copy link
Contributor

@fab-10 fab-10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not think this is the right way, since adding Blob tx here means that they are considered valid even before Cancun, that is against the protocol specs, since we can accept as valid blocks containing them when still on Shanghai.
We need to understand better the scope of the Hive test and in case change it.

I remember that this was discussed during a ACDE call, and we agreed that tests should not expect blob tx to be present in the pool for the fork block.

@jflo
Copy link
Contributor Author

jflo commented Sep 28, 2023

I do not think this is the right way, since adding Blob tx here means that they are considered valid even before Cancun, that is against the protocol specs, since we can accept as valid blocks containing them when still on Shanghai. We need to understand better the scope of the Hive test and in case change it.

I remember that this was discussed during a ACDE call, and we agreed that tests should not expect blob tx to be present in the pool for the fork block.

ok, that makes sense. Will close this PR, and need more time to open a more extensive one that allows the set of allowedTransaction types to change as the protocol schedule passes.

@jflo jflo closed this Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants