-
-
Notifications
You must be signed in to change notification settings - Fork 204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add resetDefaultValueLocale option #451
Add resetDefaultValueLocale option #451
Conversation
Codecov Report
@@ Coverage Diff @@
## master #451 +/- ##
==========================================
+ Coverage 90.48% 91.83% +1.34%
==========================================
Files 12 12
Lines 778 796 +18
==========================================
+ Hits 704 731 +27
+ Misses 74 65 -9
Continue to review full report at Codecov.
|
@karellm any update here? I think several people could benefit from this change being merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, it looks good. My only concern is that I would like more test at the parser level. I don't like the code coverage reduction. Could you add some while you address my other comment about the README?
No problem, I should have an update shortly. |
916cd55
to
f836445
Compare
f836445
to
80be955
Compare
@karellm any update on this PR? Looks like the changes you requested have been addressed. |
Hey @karellm, any remaining issues with these changes? |
Sorry for the delay. Thanks for the great work, I'm deploying it as |
Why am I submitting this PR
Add a feature related to resetting translations for a key if the default value changes.
Does it fix an existing ticket?
Yes #267
Checklist
yarn test
(see details here)