Make sure that catalog values are properly updated #4194
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Noticed a quirk in app string catalog generation. While the new catalog generation logic handles the addition and removal of strings to
app_strings.tsx
, it doesn't handle updates to existing strings.So imagine we have the following in
app_strings.tsx
:The catalog will contain:
If we then edit
app_strings.tsx
, e.g.:The catalog should read:
But it'll currently remain unchanged.
This PR addresses this gap with a config tweak. The relevant config field is a bit abstractly named. But you can see how it does what we want by following this issue to its conclusion: i18next/i18next-parser#267 ➡️ i18next/i18next-parser#451.
Testing Plan