Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Dialog): Add data-iui-placement functionality #1323

Merged
merged 15 commits into from
Jun 6, 2023
Merged

feat(Dialog): Add data-iui-placement functionality #1323

merged 15 commits into from
Jun 6, 2023

Conversation

marashad001
Copy link
Contributor

#1313 Dialog positioning

  • Change positioning of dialog on page in React using data-iui-placement.
  • New position prop, tests and image.

@marashad001 marashad001 requested review from a team as code owners June 1, 2023 19:28
@marashad001 marashad001 requested review from mayank99 and LostABike and removed request for a team June 1, 2023 19:28
@mayank99
Copy link
Contributor

mayank99 commented Jun 1, 2023

Add changeset, update documentation page, and please do not delete the PR template next time. It exists to remind you of these things.

mayank99
mayank99 reviewed Jun 2, 2023
View reviewed changes
.changeset/config.json Outdated Show resolved Hide resolved
.changeset/real-wombats-fly.md Outdated Show resolved Hide resolved
apps/storybook/src/Dialog.stories.tsx Outdated Show resolved Hide resolved
apps/storybook/src/Dialog.stories.tsx Outdated Show resolved Hide resolved
apps/storybook/src/Dialog.stories.tsx Show resolved Hide resolved
LostABike
LostABike approved these changes Jun 5, 2023
View reviewed changes
Copy link
Contributor

@LostABike LostABike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functionality seems good! Just some small comments I have above.

@marashad001 marashad001 added this pull request to the merge queue Jun 6, 2023
@marashad001 marashad001 removed this pull request from the merge queue due to a manual request Jun 6, 2023
@marashad001 marashad001 added this pull request to the merge queue Jun 6, 2023
Merged via the queue into iTwin:dev with commit f0bdcef Jun 6, 2023
@marashad001 marashad001 deleted the malik/dialog-position-react branch June 6, 2023 19:54
@imodeljs-admin imodeljs-admin mentioned this pull request Jun 6, 2023
Merged
@mayank99 mayank99 linked an issue Jun 7, 2023 that may be closed by this pull request
Dialog: positioning #1313
Closed
@mayank99 mayank99 mentioned this pull request Jul 18, 2023
Closed
@mayank99 mayank99 mentioned this pull request Jul 26, 2023
Merged
@imodeljs-admin imodeljs-admin mentioned this pull request Oct 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretanausedaite gretanausedaite gretanausedaite left review comments

@mayank99 mayank99 mayank99 approved these changes

@LostABike LostABike LostABike approved these changes

Assignees

@marashad001 marashad001

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dialog: positioning
4 participants
@marashad001 @mayank99 @LostABike @gretanausedaite