-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
css modules #1302
Merged
Merged
css modules #1302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
a team,
gretanausedaite and
LostABike
and removed request for
a team
May 23, 2023 12:45
This was referenced May 23, 2023
All styles and tests should be fixed now. |
mayank99
force-pushed
the
mayank/css-modules
branch
from
June 6, 2023 21:40
c133f8d
to
cfd43eb
Compare
mayank99
force-pushed
the
mayank/css-modules
branch
from
June 6, 2023 21:41
cfd43eb
to
d69f216
Compare
gretanausedaite
approved these changes
Jun 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Created a
styles.js
folder insidesrc
that uses Vite to do CSS-modules processing. After processing, theiui-
prefix becomes_iui3-
(for exampleiui-button
becomes_iui3-button
). Not including hash yet to ease migration, but it will be a one-line change to add it in v4.Vite will output two files:
styles.css
andstyle.js
, both of which get copied into the published output of@itwin/itwinui-react
. Thestyles.css
file will need to be imported manually by users, and thestyles.js
file will be used insidepolymorphic
to get the transformed class names.Made some tweaks in
@itwin/itwinui-css
to remove previous scoping mechanism (from #1031). Added:where
to@itwin/itwinui-variables
and requirediui-root
in all global styles.Pending issues:
added exception for Table because it will be rewrittenSee branch preview: https://itwin.github.io/iTwinUI/1302/react/
Testing
Tested running dev and prod build of playgrounds and storybook. More extensive testing needed.
Docs
Updated starter templates and "getting started" pages. Added multiple changesets.
Updated migration guide: https://github.com/iTwin/iTwinUI/wiki/iTwinUI-react-v3-migration-guide#breaking-changes