Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix website styles #1335

Merged
merged 10 commits into from
Jun 8, 2023
Merged

fix website styles #1335

merged 10 commits into from
Jun 8, 2023

Conversation

mayank99
Copy link
Contributor

@mayank99 mayank99 commented Jun 7, 2023 •
edited
Loading

Changes

After #1302, some website demos broke, so fixing them.

In a future PR, i might move all iTwinUI-specific stuff into shadow dom to prevent conflicts with the page.

Testing

All pages look fine now.

Docs

N/A

@mayank99 mayank99 marked this pull request as ready for review June 7, 2023 17:56
@mayank99 mayank99 requested review from a team as code owners June 7, 2023 17:56
@mayank99 mayank99 requested review from gretanausedaite and LostABike and removed request for a team June 7, 2023 17:56
@mayank99 mayank99 self-assigned this Jun 7, 2023
@mayank99 mayank99 mentioned this pull request Jun 7, 2023
Merged
7 tasks
@mayank99 mayank99 requested a review from FlyersPh9 June 7, 2023 17:59
LostABike
LostABike reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@LostABike LostABike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dropdown menus all missing styles/background I think?
image

@mayank99
Copy link
Contributor Author

mayank99 commented Jun 8, 2023

dropdown menus all missing styles/background I think?

good catch. I could fix this using appendTo='parent', but we don't want our users to start adding that everywhere, so it's better to leave the snippets unchanged.

I think it might be fixed by #1300 though. Could you review that? We can merge and then update this branch to see if it's fixed.

@LostABike
Copy link
Contributor

dropdown menus all missing styles/background I think?

good catch. I could fix this using appendTo='parent', but we don't want our users to start adding that everywhere, so it's better to leave the snippets unchanged.

I think it might be fixed by #1300 though. Could you review that? We can merge and then update this branch to see if it's fixed.

ok I'll take a look

@mayank99 mayank99 force-pushed the mayank/fix-website-styles branch from 88e51ce to c9836b6 Compare June 8, 2023 18:50
@mayank99
Copy link
Contributor Author

mayank99 commented Jun 8, 2023

Unfortunately #1300 didn't fix it, so I've made use of the internal _iui3-root class for now to fix demos. aade838

Will investigate some more later.

LostABike
LostABike approved these changes Jun 8, 2023
View reviewed changes
Copy link
Contributor

@LostABike LostABike left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think I checked everything, and they all work as intended now 😅

@mayank99 mayank99 merged commit 6b197cd into dev Jun 8, 2023
@mayank99 mayank99 deleted the mayank/fix-website-styles branch June 8, 2023 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gretanausedaite gretanausedaite gretanausedaite approved these changes

@LostABike LostABike LostABike approved these changes

@FlyersPh9 FlyersPh9 Awaiting requested review from FlyersPh9

Assignees

@mayank99 mayank99

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mayank99 @LostABike @gretanausedaite