fix resizable dialog issues #1424
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
gretanausedaite and
adamhock
and removed request for
a team
gretanausedaite
approved these changes
Jul 24, 2023
This was referenced Jul 24, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
overflow: hiddento dialog.min-heightto all dialogs rather than only draggable ones. Based on Added min-height for draggable dialog #1046.:has/data-iui-flexto adddisplay: flexonly whenDialog.Contentis used. This is the same as feat(Dialog): All variants useflex#1269 but non-breaking.All of these changes help towards points 1, 2 and 5 mentioned in iTwin/appui#363 (comment).
Testing
Before:
Screen.Recording.2023-07-21.at.12.08.36.PM.mov
After:
Screen.Recording.2023-07-21.at.12.06.52.PM.mov
Docs
Added changeset.