-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move dialog resizers into shadow dom #1836
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
907202c
to
122494f
Compare
I don't think I'm the best person to review the |
r100-stack
reviewed
Feb 8, 2024
r100-stack
reviewed
Feb 8, 2024
Co-authored-by: Rohan Kadkol <[email protected]>
r100-stack
approved these changes
Feb 8, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
This is a slight refactor of the
Resizer
component used inDialog
.<style>
here (vs inline styles) without causing performance issues.overflow
, which was recently removed in removeoverflow
and inlinetransform
from Dialog #1795).Internal change: Extracted out
ShadowTemplate
into a shared component and renamed toShadowRoot
. Updated the logic inside to correctly handle isomorphic rendering (via declarative syntax). Also added aflushSync
to immediately force a re-render (needed bycreatePortal
); this ensures that any layout measurements are immediately reflected correctly. This is important because the Dialog resizing logic immediately measures the DOM inside auseLayoutEffect
and was reporting incorrect measurements if the shadow root content was not present on first mount.Testing
Updated affected unit tests. Since
attachShadow
is called insidequeueMicrotask
, I had to use fake timers.Manually tested that resizing works correctly. Inspect the Resizable Dialog story and play with it in devtools to understand the new changes.
Docs
Added changeset for the one-user facing change.