add development checks for displayName
#2141
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
There was a problem hiding this comment.
A couple of components, Alert.Message, and ListItem.Content still have their displayName values set in the prod build output.
mayank99
commented
Jul 15, 2024
There was a problem hiding this comment.
@Ben-Pusey-Bentley Good catch, thanks. Fixed in 61bbc8b.
I did a global "find" in the esm/ folder to verify there are no remaining instances.
Ben-Pusey-Bentley
approved these changes
Jul 15, 2024
r100-stack
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #2131, all
displayNames are now conditionally added only during development.While this shouldn't make a big difference in the bundle size, the code is only useful for React developer tools, and does add up over time when there are lots of components, so it's good to not have it in the prod build.
Testing
Manually inspected the build outputs to verify that
.displayNameassignments are correctly present only in the dev build and removed from the prod build.Docs
Added patch changeset.