add missing displayNames
#2142
Merged
add missing displayNames
#2142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mayank99
requested review from
r100-stack and
Ben-Pusey-Bentley
and removed request for
a team
mayank99
force-pushed
the
mayank/displayNames-missing
branch
from
653c0e3 to
514353a
Compare
Ben-Pusey-Bentley
approved these changes
Jul 15, 2024
An error occurred while trying to automatically change base from
mayank/displayName-dev
to
main
July 16, 2024 14:24
r100-stack
approved these changes
Jul 16, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Follow-up to #2141. Added
displayNameto every public-facing component.This is necessary for React dev-tools (and React errors), which will otherwise use unhelpful names like "Anonymous".
Testing
Verified that displayNames are correctly utilized by React dev-tools.
Docs
Added patch changeset.