Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rc/1.84.0 #1069

Merged
merged 13 commits into from
Oct 16, 2023
Merged

Rc/1.84.0 #1069

merged 13 commits into from
Oct 16, 2023

Conversation

demariadaniel
Copy link
Contributor

Description of changes

TSV API Endpoint:
icgc-argo/argo-clinical#1062

Lost to Follow Up:
icgc-argo/argo-clinical#1067
icgc-argo/argo-clinical#1066
icgc-argo/argo-clinical#1061

Clinical Data Resolvers:
icgc-argo/argo-clinical#1051

Small Submission Data Resolvers:
icgc-argo/argo-clinical#1060

Registration Mutation: icgc-argo/argo-clinical#1057

Clear Submission Mutation: icgc-argo/argo-clinical#1055

Validate Submission Mutation: icgc-argo/argo-clinical#1058

Type of Change

  • Bug
  • Refactor
  • New Feature
  • Release Candidate

Checklist before requesting review:

  • Check branch (code change PRs go to develop not master)
  • Check copyrights for new files
  • Manual testing
  • Regression tests completed and passing (double check number of tests).
  • Spelling has been checked.
  • Updated swagger docs accordingly (check it's still valid)
  • Set validationDependency in meta tag for Argo Dictionary fields used in code

UmmulkiramR and others added 13 commits September 14, 2023 13:55
* Added auth

* Added the clear clinical submission query and auth related changes

* auth changes

* some code refactoring

* some code refactoring

* removed commented code

* added reference to EgoJwtData

---------

Co-authored-by: UmmulkiramR <[email protected]>
* Added auth

* Added the clear clinical submission query and auth related changes

* auth changes

* some code refactoring

* some code refactoring

* removed commented code

* added validateClinicalSubmissions resolver

* Added the commitClinicalSubmissionResolver

* removed unwanted code

---------

Co-authored-by: UmmulkiramR <[email protected]>
* First Stubs

* First Files + Spelling Corrections

* ClearRegistration + Copyright

* Working Commit Registration

* Fix Clear Registration

* Current state (not working)

* Revert "Current state (not working)"

This reverts commit bbd7367.

* Cleanup

* Import Mixup

* Missing Copyright

* Add resolve/reject w/ error handling
* Base Files

* Type Defs, Remove Repeated Chars

* First Round Working ClinicalSubmissionTypesList

* Updated SchemaVersion

* Working Clinical Submission Disabled

* Clean Up Resolvers

* Make getSchemas more DRY

* Remove extra .then

* Updated Type Assertion
* graphql server creation

* added console logger.

* corrections needed due to typescript version upgrade

* adjusted dependency versions

* added clinical registration query

* code refatoring

* code refatoring

* First Working Version

* Move Into Sub Folder

* Refactor Clinical Errors + Add Resolvers

* Add GQL TypeDefs

* Type + Resolver Updates

* Fix Imports + Returns

* Fix Search Results

* Fix Up Clinical Errors

* Add Convert to GQL Functions

* Remove Always True Boolean

* Update Unit Test

* Fix bad merge

* No null clinical errors

* Updated Async + Resolvers

* Streamline Clinical Errors Logic

* Updated Async

* Simplified Type

* Updated Donor Type + Comment

* Additional Partial

* Updated Display Record logic

* Remove unnecessary

* Use 'Type &' syntax

* Missing Copyrights

* Updated Synchronous Solution

* Code Review changes from #1007

* Unnecessary Await

---------

Co-authored-by: UmmulkiramR <[email protected]>
* Remove Diagnosis Code

* Initial update

* Make Types Common (draft)

* Current Working State

* Some reorg

* Organization + Cleaning

* Revert "Make Types Common (draft)"

This reverts commit de3714b.

* Move diagnosisMatch back

* Reorder conditional

* Major Update

* Clean up filter functions

* Updated Method Types
* Remove noisey startup logging

* Repo can fetch donors by ID without program parameter

* Clinical Service and Task support to get Donors by ID

* Clinical API Endpoint to download clinical TSVs by Donor ID

* remove unnecessary `await` on returned promise

Co-authored-by: Anders Richardsson <[email protected]>

* Line spacing for readability

Co-authored-by: Anders Richardsson <[email protected]>

---------

Co-authored-by: Anders Richardsson <[email protected]>
Alpine does not have `curl` which is needed for slack integration job
* Filter by Primary Diagnosis ID

* Testing First Solution

* First Refactor + New Unit Test

* Finished Refactor w/ New Unit Test

* Map Reduce Solution
* First Refactor

* Remove Logging

* Update Age Calculation

* Update Units Tests

* Updated Diagnosis Logic + Errors

* Shorten Variable Name

* Updated Copy
@demariadaniel demariadaniel merged commit 9687b09 into master Oct 16, 2023
@demariadaniel demariadaniel deleted the rc/1.84.0 branch October 16, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants