Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync ebml matroska with ebml schema definition #325

Merged
merged 3 commits into from
Jul 30, 2019
Merged

Sync ebml matroska with ebml schema definition #325

merged 3 commits into from
Jul 30, 2019

Conversation

dericed
Copy link
Contributor

@dericed dericed commented Jul 8, 2019

This is an alternate pr to #320 and #321 but is dependent on a merge of ietf-wg-cellar/ebml-specification#270.

td;lr it moves the cppname, divx and webm attributes from element to element/extension

@dericed dericed requested review from mcr and robUx4 July 8, 2019 19:37
This was referenced Jul 11, 2019
Closed
Closed
@robUx4
Copy link
Contributor

robUx4 commented Jul 13, 2019

Besides the dicussion about the way we can handle extra elements, I suppose you generate this using a tool (XSLT script ?) I would be good to put the script in transform/ in the same PR so it can be reused, tweaked, validated.

@robUx4 robUx4 added formatting spec_main Main Matroska spec document target webm WebM specific documentation labels Jul 13, 2019
robUx4
robUx4 reviewed Jul 13, 2019
View reviewed changes
@dericed dericed force-pushed the sync-ebml_matroska-with-ebml-schema-definition branch 2 times, most recently from 172e119 to 0bd151d Compare July 13, 2019 12:06
@dericed
Copy link
Contributor Author

dericed commented Jul 13, 2019

@robUx4 I did not use an xslt to generate this but careful editing.

@robUx4 robUx4 mentioned this pull request Jul 13, 2019
Merged
@robUx4 robUx4 added the XML Schema EBML Schema validation label Jul 13, 2019
@robUx4
Copy link
Contributor

robUx4 commented Jul 13, 2019

not use an xslt to generate this but careful editing

OK, I'll do a XSLT for that. I only trust machines 🤣

IMO these should be different PRs. The type ->purpose patch can already be merged IMO. The namespace addition too (see #328).

The extra extension IMO needs more debate.

@robUx4 robUx4 mentioned this pull request Jul 13, 2019
Merged
@robUx4 robUx4 force-pushed the sync-ebml_matroska-with-ebml-schema-definition branch from 0bd151d to cbbbae6 Compare July 14, 2019 15:29
@robUx4
Copy link
Contributor

robUx4 commented Jul 14, 2019

Rebased on top of #328 (ebml: instead of e:).
And I pushed f6b04ba076aadab6c9bde9c20006caac4603049e which is OK and unrelated to the extension change.

@robUx4 robUx4 force-pushed the sync-ebml_matroska-with-ebml-schema-definition branch 2 times, most recently from e1c5449 to 14baa04 Compare July 14, 2019 15:52
@robUx4
Copy link
Contributor

robUx4 commented Jul 14, 2019

Added a XSLT script that transformed the old ebml_matroska.xml into the one with a single extension.
It will collide with #329

dericed and others added 2 commits July 23, 2019 20:32
@dericed @robUx4
move local attributes to extension
56c16d0
@robUx4
Automate the cleaning of ebml_matroska.xml
9ea12f3 
- Now the order is fixed by the ebml_schema2clean.xsl script
- Each documentation now has a purpose (which is a mandatory attribute)
- webm, divx and cppname are put in a single extension (for now)
@robUx4 robUx4 force-pushed the sync-ebml_matroska-with-ebml-schema-definition branch from 14baa04 to 9ea12f3 Compare July 23, 2019 18:35
@robUx4
rerun the script on the original ebml_matroska.xml
21a0129 
each extension is now separate and could have its own comments
@robUx4 robUx4 mentioned this pull request Jul 23, 2019
Closed
@dericed
Copy link
Contributor Author

dericed commented Jul 30, 2019

LGTM, I suggest to merge soon. I'd like to start working on implementation_notes after this pr.

@mcr mcr merged commit 7da61bf into master Jul 30, 2019
@dericed dericed deleted the sync-ebml_matroska-with-ebml-schema-definition branch July 30, 2019 20:57
@nerg4l nerg4l mentioned this pull request Feb 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robUx4 robUx4 robUx4 left review comments

@mcr mcr Awaiting requested review from mcr

Assignees
No one assigned
Labels
formatting spec_main Main Matroska spec document target webm WebM specific documentation XML Schema EBML Schema validation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dericed @robUx4 @mcr