Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean schema #329

Merged
merged 3 commits into from
Jul 22, 2019
Merged

Clean schema #329

merged 3 commits into from
Jul 22, 2019

Conversation

robUx4
Copy link
Contributor

@robUx4 robUx4 commented Jul 13, 2019

Goes on top of #328

Collides with #325 by removing divx, webm and cppname, until we find a proper way to handle them.

robUx4 added 3 commits July 13, 2019 14:47
So it can be validated properly

Adjust the XSLT transform to match the elements with a non-empty namespace
Ultimately ebml_matroska.xml will go away or will be replaced with this one.
@robUx4 robUx4 added spec_main Main Matroska spec document target XML Schema EBML Schema validation labels Jul 13, 2019
xsltproc transforms/schema_clean.xsl ebml_matroska.xml > $@

check: matroska_xsd.xml
xmllint --noout --schema ../ebml-specification/EBMLSchema.xsd matroska_xsd.xml
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a new thing and requires the EBML specification repo to be downloaded in a certain place.
This could be used to validate changes to the Matroska Schema on Github before allowing a push.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

Copy link
Contributor

@dericed dericed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK with this, and with it superseding #325

@dericed dericed merged commit 2d56b71 into master Jul 22, 2019
@dericed dericed deleted the clean-schema branch July 22, 2019 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
spec_main Main Matroska spec document target XML Schema EBML Schema validation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants